search

microsoft / windows-dev-center-vsts-extension

Visual Studio Team Services (VSTS) extension for performing continuous delivery to the Windows Dev Center store from your automated CI builds
Other
42 stars 18 forks source link

Won't upload StoreLogo9x16 image #83

Closed tesar-tech closed 4 years ago

tesar-tech commented 4 years ago

So. I set up pipeline and almost everything works just fine, screenshots upload included.

I need to also update StoreLogo9x16 image, but it won't appear in a store submission.

This is folder structure I tried (see attempt 1 and attempt 2):

appMetadata
\---en-us
    \---baseListing
        |   metadata.json
        |
        \---images
            |   StoreLogo9x16.png //attempt 1
            |
            +---Screenshot
            |       screenshot01.metadata.json
            |       screenshot01.png
            |       screenshot02.metadata.json
            |       screenshot02.png
            |
            \---StoreLogo9x16
                    StoreLogo9x16.png //attempt 2

I also tried adding json metadata file. But without success. Am I doing something wrong here?

You can see the project here: https://github.com/tesar-tech/StoreUp/tree/master/NoApp/Store/appMetadata/en-us/baseListing

tesar-tech commented 4 years ago

It is probably caused by missing values in imageType array (https://github.com/microsoft/windows-dev-center-vsts-extension/blob/master/tasks/store-publish/publish.ts#L19). StoreLogo9x16 and StoreLogoSquare are missing. Values are taken from here.

Could someone look at this?

louis-wuitton commented 4 years ago

Hi @tesar-tech , sorry for the delay. I looked into the extension and you are right, the supported imageType array is outdated. I updated imageType array for the extension so check to see if it works for you. Thanks!

louis-wuitton commented 4 years ago

Created PR to address this issue: #88

tesar-tech commented 4 years ago

It work's now. Thanks.