search

microsoft / windows-rs

Rust for Windows
https://kennykerr.ca/rust-getting-started/
Apache License 2.0
10.13k stars 473 forks source link

Add `no-default-features` yml workflow #3053

Closed kennykerr closed 1 month ago

kennykerr commented 1 month ago

Following up on https://github.com/microsoft/windows-rs/pull/3047#discussion_r1605448388 where @dpaoliello suggested we test crates with no default features.

kennykerr commented 1 month ago

@ChrisDenton here's some more fallout from the unexpected_cfgs thing.

https://github.com/microsoft/windows-rs/actions/runs/9207820449/job/25328694260?pr=3053

kennykerr commented 1 month ago

Actually looking closer it might be an unrelated nightly change.

https://rust-lang.github.io/rust-clippy/master/index.html#/lint_groups_priority

ChrisDenton commented 1 month ago

Yeah, I think it's basically saying that unused_qualifications is redundant because it's already being set in rust_2018_idioms.

ChrisDenton commented 1 month ago

Aside: lint changes have been exhausting recently.

kennykerr commented 1 month ago

Yes, really losing the value for me.

ChrisDenton commented 1 month ago

Oh, looks like you were right the first time. It seems that any group has to be priority -1 even if it doesn't include the lint.

kennykerr commented 1 month ago

Yep, that's super confusing.