microsoft / windows-rs

Rust for Windows
https://kennykerr.ca/rust-getting-started/
Apache License 2.0
10.13k stars 473 forks source link

rustc nightly (2024-06-06+) flags unused-qualifications in a way that is not backward compatible #3076

Closed sivadeilra closed 1 month ago

sivadeilra commented 1 month ago

Summary

On 6/5/2024, PR jobs started failing due to new warnings added in Rust nightly. The warnings suggest replacing core::mem::size_of with simply size_of because core::mem::size_of has been added to the standard prelude. However, making this change would break existing code when using pre-1.80.0 compilers, so the only good fix is to add use core::mem::size_of in lots of places.

I'm opening this issue to track the problem and to have a place to link PRs that work around the problem in the short term.

Crate manifest

No response

Crate code

No response