search

microsoft / windows-rs

Rust for Windows
https://kennykerr.ca/rust-getting-started/
Apache License 2.0
10.1k stars 473 forks source link

Test cross-compilation with stable gnullvm targets #3104

Closed mati865 closed 2 weeks ago

mati865 commented 3 weeks ago

Continuation of https://github.com/microsoft/windows-rs/pull/3007 but this time with a stable toolchain.

mati865 commented 3 weeks ago

It looks like a preinstalled stable toolchain was not yet updated to the latest version.

kennykerr commented 2 weeks ago

When do you expect that to be updated?

mati865 commented 2 weeks ago

Judging by the history of https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md, I'd expect it to happen today, but I don't have the details on how GitHub updates their images.

riverar commented 2 weeks ago

Rather than wait for GitHub, which might be busy/frozen due to events this week, can we just update the tools at start of the workflow (like we already do)?

mati865 commented 2 weeks ago

If this fails again, I'll look into incorporating changes from other workflows to make sure Rust is up to date.

kennykerr commented 2 weeks ago

I don't know if this is related but GNU builds have started failing:

https://github.com/microsoft/windows-rs/actions/runs/9567088234/job/26373942886

ChrisDenton commented 2 weeks ago

It looks like a Windows Server 2022 update is currently in progress so it shouldn't be too long now.

mati865 commented 2 weeks ago

Even though GHA docs were updated yesterday so the compiler should be up-to-date now I added the step to update the toolchain like in the other jobs.

It looks like a Windows Server 2022 update is currently in progress so it shouldn't be too long now.

That's good, I guess? Don't know how it's related, though.

I don't know if this is related but GNU builds have started failing:

microsoft/windows-rs/actions/runs/9567088234/job/26373942886

It uses GHA image 20240610.1.0 so it's unlikely to be related. Probably something in nightly or rustup. Maybe it's related to https://github.com/rust-lang/rust/issues/125809?

riverar commented 2 weeks ago

You can ignore the previous build error, we root caused that and fixed it here https://github.com/microsoft/windows-rs/pull/3111#issuecomment-2176423129

mati865 commented 2 weeks ago

Ah, forgot about Mac.

Added if: startsWith(matrix.image, 'ubuntu-') && contains(matrix.target, 'gnullvm') || endsWith(matrix.target, 'gnu') to Test step so the tests for gnullvm won't run there, but it's still not ideal since there are 3 macos gnullvm jobs that basically do checkout exit with success. Still, it's an improvement compared to the master branch, so good to go?

kennykerr commented 2 weeks ago

Hmm, just noticed those unused mac tests. We can clean those up separately.