search

microsoft / winfile

Original Windows File Manager (winfile) with enhancements
MIT License
6.75k stars 697 forks source link

No Russian language #243

Open Anixx opened 4 years ago

Anixx commented 4 years ago

Even though the original Winfile had it

craigwi commented 4 years ago

See discussion in #77. Also, all of the original language files that I could recover are in src\origrc.

clzls commented 4 years ago

If you can read Russian, you may check is this translation ok: https://github.com/microsoft/winfile/blob/master/src/origrc/winfile.ru-RU.rc https://github.com/microsoft/winfile/blob/master/src/origrc/winfile.en-US.rc

and we may add Russian into the release in the future, if you want to help... (Since we are not native Russian speakers...)

Anixx commented 4 years ago

How can I check it if it is displayed with garbage symbols?

ZanderBrown commented 4 years ago

GitHub/Browser has probably assumed UTF which code_page(1251) isn't, try changing browser encoding/opening locally

clzls commented 4 years ago

See discussion in #77. Also, all of the original language files that I could recover are in src\origrc.

Like Polish, the original rc files of other languages also need to be converted to UTF-8... (But it seems that only ru-RU is totally unreadable? Even zh-CN, ja-JP, ko-KR are fine...)

clzls commented 1 week ago

How can I check it if it is displayed with garbage symbols?

@Anixx Repaired with PR #250 and merged, now it is readable. But I don't know how to "convert"/"adapt" a single .rc file into res_ru-RU.rc suggest_ru-RU.db winfile_ru-RU.dlg automatically. May @craigwi have any good idea?

craigwi commented 1 week ago

In the current sources res_en-US.rc includes winfile_en-US.dlg. I don't know why this was separated. res_ru-RU.rc appears to include content for both and so it might be possible to just add that one file and update the #include and other stuff. suggest_ru-RU.db would have to be created from scratch (e.g., by copying another language).

clzls commented 4 days ago

In the current sources res_en-US.rc includes winfile_en-US.dlg. I don't know why this was separated. res_ru-RU.rc appears to include content for both and so it might be possible to just add that one file and update the #include and other stuff. suggest_ru-RU.db would have to be created from scratch (e.g., by copying another language).

I see. I may be able to carry out some tests then. For the latter step we still need some native speakers of Russian to do that though...

malxau-msft commented 4 days ago

In the current sources res_en-US.rc includes winfile_en-US.dlg. I don't know why this was separated.

I looked into this; it was split from the initial 1991 fork. I'm 90% sure this is an artifact of the limitations of the 3.0 Dialog Editor; we didn't have integrated resource editing back then, so the dialog editor only understood dialog resources. It reads the (compiled) .res file and writes the (textual) .dlg file containing only dialogs. If they were in one .rc file, the dialog editor could not have been used.

Since res_rc-RU.rc is extracted from a binary, it didn't preserve its original source structure.

suggest_ru-RU.db would have to be created from scratch (e.g., by copying another language).

For the latter step we still need some native speakers of Russian to do that though...

All the strings are in the .rc, right? 1101-1118 and 1150-1155 are all there, it's just turning these back into macros.