microsoft / winfile

Original Windows File Manager (winfile) with enhancements

MIT License

6.85k stars 709 forks source link

in BagOValues.h #247

Closed nietoperz809 closed 4 years ago

nietoperz809 commented 4 years ago

include

... is missing. otherwise, the compiler doesn't find 'wstring'

craigwi commented 4 years ago

I don't understand. What is include is missing where? And what means are you using to compile?

There are no such issues using Visual Studio.

nietoperz809 commented 4 years ago

I use VS community 2019 I must #include <string> at the top of this file, otherwise wstring isn't found.

craigwi commented 4 years ago

Same here (VS 2019) -- and I am not seeing the issue. Perhaps I have certain VS feature packages installed that you don't...

nietoperz809 commented 4 years ago

That can be the reason. I have kicked out much .NET stuff that I probably never will need.

After cloning the winfile from Github I double-clicked the sln-file to open the project. Then I had it to retarget to 'v142' since I haven't vs 2017 build tools installed.

craigwi commented 4 years ago

So this could be an issues with the v2 2019 tools? Seems like a simple fix in any case.

nietoperz809 commented 4 years ago

It looks like the c++ header 'string' is already known by the compiler in your setup. perhaps a compiler switch?

btw, some months ago I've built winfile from the leaked win2k sources, and progman too, that was much fun :)

craigwi commented 4 years ago

I doubt it is a compiler switch since that would be part of your build too.

I have VS 2017 installed too and Winfile rebuilds cleanly.

Thus it looks like an issue when re-targeting Winfile to 2019 tools. Can others confirm?

craigwi commented 4 years ago

I talked to the C++ team yesterday that deals with this and they said there was probably a refactoring of the includes and it was reasonable to just add the #include as suggested. Thanks @nietoperz809.