microsoft / winfile

Original Windows File Manager (winfile) with enhancements
MIT License
6.82k stars 706 forks source link

Hotkey for opening New Window on search result #328

Closed schinagl closed 2 years ago

schinagl commented 2 years ago

Problem

  1. There is no hotkey avaiable on the search menu to open the containing folder of an item. This only works via right mouse and select first entry from popup-menu
  2. If a search is executed on a hidden or system folder, and one selects to open a 'New Window' from the pop-up on the search outputs, the New Window always shows the root of the active drive.

Improvements

When selecting an item on the search folder, one can now press CTRL + Shift + Enter to open a 'New Window' with the containing folder from the selected search result. This now also works if the result was on hidden folder. The New Window opens with the containing folder.

About the code

The easy part was to extended accelerator table. Fixing this for hidden or system folders is done by forwarding the attributes to the search folder. This was simply missing.

craigwims commented 2 years ago

While in the search results page, Alt+W, Alt+N does the same thing -- or am I missing something?

schinagl commented 2 years ago

Almost all functionality can be reached via the menu, here ALT+W N. Correct.

I think in this very case it makes sense to use the freely available CTRL + SHIFT + ENTER to open a new window, because it is something you do often. Furthermore CTRL + SHIFT + ENTER falls into the category of 'doing' something with a file: ENTER == Execute file CTRL + ENTER == Execute file as admin ALT + ENTER == Show properties of file CTRL + SHIFT + ENTER == Open a new window with the files location