microsoft / winfile

Original Windows File Manager (winfile) with enhancements
MIT License
6.76k stars 699 forks source link

Fix x64 warning about incremental linking with COMDAT folding #372

Closed malxau closed 1 year ago

malxau commented 1 year ago

I've been getting warnings recently on x64 about incompatible linking options, which probably occurred as part of the 2019 compiler upgrade. The warning is complaining about using /INCREMENTAL with /OPT:ICF. I think incremental is odd, since this is used for Debug but not Release builds on x86 and arm64, but for some reason x64 uses incremental linking on Release too. So this resolves the warning by making x64 linking consistent with the others.