search

microsoft / winfile

Original Windows File Manager (winfile) with enhancements
MIT License
6.76k stars 699 forks source link

Remove unused defines #375

Closed malxau closed 1 year ago

malxau commented 1 year ago

This is to remove #define values that were carried forward from the Windows build environment and are not used. These have mostly already been removed from C code but were still used in RC compilation. I verified they are not used in winfile or in the SDK headers that it includes.

Note this changes _M_IX86 to _M_IX64 for x64 builds. These should normally be defined by the compiler but are explicitly defined here. It's not safe to get these wrong since it may result in incorrect structure definitions. Since this is specific to the resource compiler it doesn't seem like a big risk, but still.

schinagl commented 1 year ago

Works on my side so at least a second pair of eyes is fine. I think we are good to go