microsoft / winfile

Original Windows File Manager (winfile) with enhancements
MIT License
6.76k stars 699 forks source link

Remove register keyword which is obsolete #390

Closed malxau closed 1 year ago

malxau commented 1 year ago

Compiling with clang generates some new warnings. One of these is the use of the register keyword. As far as I know and have been able to find out, this has been ignored by all 32 bit and 64 bit compilers. The winfile code appears to depend on this keyword being ignored, because it includes this keyword on parameters used by callback functions where the calling convention is defined by the operating system.

The x64 calling convention uses four registers for the first four parameters and has more registers available for locals, which has rendered this keyword more thoroughly obsolete.