microsoft / winfile

Original Windows File Manager (winfile) with enhancements
MIT License
6.75k stars 698 forks source link

Make 'Other:' text in MOVECOPY dialog localizable #401

Closed malxau closed 10 months ago

malxau commented 11 months ago

Continuing from #400 . This is a crude change to make the Other: text localizable. For en-US I changed it to be a bit more descriptive, which is built on the assumption that the dialog will be large enough to accommodate it.

Note the current directory at the top of the dialog has some nice logic in SetDlgDirectory to truncate from the middle if it doesn't fit. It would be really nice to do something similar here, but this text can contain an arbitrary number of components. Also note that the current dialog resource specifies this text to be on a single line only, presumably because splitting lines based on spaces in paths wouldn't create a "natural" flow for paths.

I'm tempted to make the dialog resource multi-line, use one line per drive here, and use the logic in SetDlgDirectory to truncate these intelligently if they don't fit. That's based on the observation that this dialog is wide and not high, so it has room to be larger vertically.