microsoft / winfile

Original Windows File Manager (winfile) with enhancements
MIT License
6.82k stars 706 forks source link

Update winfile version #417

Closed malxau-msft closed 6 months ago

malxau-msft commented 7 months ago

Seems like a good time to prepare a new release.

This is my first time doing this, so apologies in advance for any bumps, particularly with Store and Chocolatey releases. Getting signed binaries on Github looks straightforward.

schinagl commented 6 months ago

There is a flaw in your .sln and projects In one of the .vcxprojs you have the Any CPU configuration, but not in all. If you open a .sln via IDE, which does not have 'Any CPU' and there is one .vcxproj with 'Any CPU', all .sln will get 'Any CPU' and the .sln is modified by the IDE Since you you don't use the IDE you maybe missed this.

So how to solve this: Delete 'Any CPU' from all .vcxprojs, reopen with IDE, save. Replace all references to 'Any CPU' with an text editor. Save

You know everything is fine, when you open the .sln with the IDE, and after no changes and closing the IDE, the .sln didn't change. Currently it always changes like hell

malxau-msft commented 6 months ago

If you open a .sln via IDE, which does not have 'Any CPU' and there is one .vcxproj with 'Any CPU', all .sln will get 'Any CPU' and the .sln is modified by the IDE Since you you don't use the IDE you maybe missed this.

@schinagl I created #430 for this. Please let me know if it addresses this concern.

schinagl commented 6 months ago

430 fixes the 'Any CPU' issue