search

microsoft / winget-cli-restsource

This project aims to provide a reference implementation for creating a REST based package source for the winget client.
MIT License
245 stars 63 forks source link

Released WingetSource module incorrectly named in .ZIP #109

Open doctordns opened 3 years ago

doctordns commented 3 years ago

Brief description of your issue

In the released Microsoft.Wnget.Source module is contained in a.ZIP file with an internal folder name "Winget.RestSource-WInget.PowerShell.Source. But that is NOt the name of the module and this makes it difficult to automate the download and installation.

The file downloaded is WinGet.RestSource-Winget.PowerShell.Source.zip and inside that is a folder WinGet.RestSource-Winget.PowerShell.Source. But the module name is Microsoft.Winget.Source. In PowerShell, the module name (ie in the .PSD1 and .PSM1 files must match their parent folder name to facilitate autoloading.

For any module you folks release, have the .ZIP file, and the folder inside that Zip file be consistent with the module names in the PSD1/PSM1 files.

Steps to reproduce

Download the released zip and look at the names inside the file

Expected behavior

I would like the file name to be consistent with the folder name inside the zip file and that consistent with the module.

Given the module "Microsoft.WInget.Source|" the zip file should be Microsoft.WinGet.Source.zip and contain a folder named Microsoft.WinGet

Actual behavior

see above

Environment

PSH [DB:\]: winget --info

Windows Package Manager (Preview) v1.2.3131-preview
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22000.318
Package: Microsoft.DesktopAppInstaller v1.17.3131.0

Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
Licence Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale
RDMacLachlan commented 3 years ago

Thank you for the feedback @doctordns I will work with the team to ensure that in future releases the container, folder and file names will all match with the module name.