search

microsoft / winget-cli-restsource

This project aims to provide a reference implementation for creating a REST based package source for the winget client.
MIT License
236 stars 62 forks source link

Installer `RepairBehavior` never used by the 1.7.0 API schema? #231

Open jantari opened 7 months ago

jantari commented 7 months ago

Brief description of your issue

I saw the RepairBehavior field is new in the v1.7.0 manifest schema:

https://github.com/microsoft/winget-cli/blob/96974fbc383811617bfcc957d9d4b32126edb26f/schemas/JSON/manifests/v1.7.0/manifest.installer.1.7.0.json#L717-L719

It is a property of "Installer". However in the corresponding API schema v1.7.0, RepairBehavior is not defined as a possible property of an "Installer": https://github.com/microsoft/winget-cli-restsource/blob/f134943b3e28be3422031944db150892fda1a90d/documentation/WinGet-1.7.0.yaml#L1504

I assume this is a mistake because why would a new property be allowed in the package manifest schema but not respected / used / returned by the API schema at all?

Should a v1.7.0-compliant REST source return installers with a RepairBehavior property or not?