Winget upgrades Mozilla Firefox even when it's already upgraded

[stefanhinz]

Brief description of your issue

Mozilla Firefox is on version 89.0.2 on this Windows 10 machine (version 21H1). Winget insists it's on version 84.0.2, though, and upgrades it each time I try.

Steps to reproduce

PS C:\Users\DAW\AppData\Local\Microsoft\WindowsApps> winget upgrade Name ID Version Verfügbar Quelle

Cisco Webex Meetings Cisco.CiscoWebexMeetings 40.10.3 41.7.2.13 winget Mozilla Firefox Mozilla.Firefox 84.0.2 89.0.2 winget VNC Viewer RealVNC.VNCViewer 6.18.907.38355 6.21.406.44671 winget PS C:\Users\DAW\AppData\Local\Microsoft\WindowsApps> winget upgrade --all Gefunden Mozilla Firefox [Mozilla.Firefox] Diese Anwendung wird von ihrem Besitzer an Sie lizenziert. Microsoft ist nicht verantwortlich und erteilt keine Lizenzen für Pakete von Drittanbietern. Downloading https://download-installer.cdn.mozilla.net/pub/firefox/releases/89.0.2/win64/ru/Firefox%20Setup%2089.0.2.exe ██████████████████████████████ 53.8 MB / 53.8 MB Der Installer-Hash wurde erfolgreich überprüft Paketinstallation wird gestartet... Erfolgreich installiert (= installation successful)

PS C:\Users\DAW\AppData\Local\Microsoft\WindowsApps> winget upgrade Name ID Version Verfügbar Quelle

Cisco Webex Meetings Cisco.CiscoWebexMeetings 40.10.3 41.7.2.13 winget Mozilla Firefox Mozilla.Firefox 84.0.2 89.0.2 winget VNC Viewer RealVNC.VNCViewer 6.18.907.38355 6.21.406.44671 winget

Expected behavior

Winget shouldn't list Firefox in the upgradable installations.

Actual behavior

Firefox is erroneously listed when calling 'winget upgrade'.

Environment

PS C:\Users\DAW\AppData\Local\Microsoft\WindowsApps> winget --info
Windows Package Manager v1.0.11692
Copyright (c) Microsoft Corporation. Alle Rechte vorbehalten.

Windows: Windows.Desktop v10.0.19043.1052
Paket: Microsoft.DesktopAppInstaller v1.12.11692.0

Protokolle: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir

Links
----------------------------------------------------------------
Datenschutzerklärung        https://aka.ms/winget-privacy
Lizenzvereinbarung          https://aka.ms/winget-license
Hinweise von Drittanbietern https://aka.ms/winget-3rdPartyNotice
Startseite                  https://aka.ms/winget
Windows Package Manager version
Windows: Windows.Desktop version: Windows 10 Version 21H1 Build 19043.1052
Package: Microsoft.DesktopAppInstaller version

Any other software?

[denelon]

The Windows Package Manager sees Mozilla Firefox 84.0.2 according to Add / Remove Programs. We're doing some work on the schema with #1243. That will include adding a key so we can "auto pin" these packages in the future so we don't try to update packages that have the ability to update themselves #1163.

[rbarbrow]

@denelon, I think it would be a mistake to not upgrade all packages with the upgrade --all command maybe we could have a different argument to only upgrade items that don't have the ability to update themselves.

I would not like a situation where I had to run winget upgrade and then go to each application and check to see if it was auto upgrading and then have to do that manually. it kinda kills the point.

[stefanhinz]

When upgrading Firefox with winget, the Firefox installer dialog comes up, like it does when updating from the Firefox Help menu. Is that what you're referring to with "the ability to update themselves"? I checked Add/Remove Programs, and low and behold, I have 2 Firefox browsers installed now! This is also indicated when trying to upgrade Mozilla.Firefox from winget: `PS C:\Users\DAW\AppData\Local\Microsoft\WindowsApps> winget upgrade Mozilla.Firefox Mehrere installierte Pakete mit übereinstimmenden Eingabekriterien gefunden. Bitte verfeinern Sie die Eingabe. (Found multiple installed packages with matching input criteria. Please refine the input.) Name ID

Mozilla Firefox Mozilla.Firefox Mozilla Firefox 89.0.2 (x64 ru) Mozilla Firefox 89.0.2 (x64 ru)` What winget doesn't tell (but Add/Remove Programs does) is that the German Firefox version is "Mozilla Firefox 84.0.2 (x64 de)". So that kind of explains it, although I have no idea why winget installed a Russian version of Firefox next to the German one.

[denelon]

@rbarbrow that's an interesting view. The reason for #476 package pinning to exist is so you don't upgrade them on accident. I think we would likely consider something like adding "--force" as another argument to force pinned packages to be upgraded.

winget upgrade --all --force would force upgrade all packages including pinned packages.

[github-account1111]

Isn't this the culprit?

The Windows Package Manager sees Mozilla Firefox 84.0.2 according to Add / Remove Programs.

The fact that the current version is reported incorrectly?

Also I don't see why updating auto-updating programs through winget should be disabled. Would it cause breakage, data loss or config reset? Pretty sure you can update, say, Firefox, through a package manager on Linux.

[denelon]

Several Windows installers have their own version independent from the actual package. They are essentially stream installers. You're downloading and installing something that knows how to reach out to the Internet and pull the "latest" version of the actual package down. We're still working through edge cases with these types of installers. On Linux, it's common not necessarily to have an installer like this per se'. In some cases on linux, you're just getting a tarball of the latest files that get written to a directory. It's not quite the same paradigm all the time.

It's been a challenge to have a package that is an installer reporting version 1.x (for the installer) installing an application that is on version 84 when the program is actually installed.

[sba923]

Same here with Firefox 103.0.2 which reports itself as 103.0:

What makes it extra annoying is that the installer for 103.0.2 (invoked by winget upgrade --all) adds an unwanted desktop shortcut and even pins Firefox to the taskbar -- which I have to undo every time I run winget upgrade --all.