Winget Validate Misses Blatant Manifest Errors

[Trenly]

Brief description of your issue

Steps to reproduce

• Copy an existing manifest version folder, and paste it in the same location as a new version
• Change the package name inside all of the yaml files; e.g if the package name is Package.Name change it to PackageTest.Name
• Change the file names of all the yaml files; e.g if the file name is Package.Name.installer.yml change it to PackageTest.Name.installer.yml
• Save your changes
• Run `winget validate --manifest {path}

Expected behavior

The validation should fail in two different places.

• The filename must match the PackageIdentifier and ManifestType properties from the manifest
• The manifest file path must match the PackageIdentifier and PackageVersion from the manifest

Actual behavior

The package is passing validation.

Additional Information

PR showing failures - https://github.com/microsoft/winget-pkgs/pull/19476 Commit 1 | Pipeline Fail 1 - filename Commit 2 | Pipeline Fail 2 - file path

Environment

[winget --info]
Windows Package Manager v1.0.11692
Windows: Windows.Desktop v10.0.19042.1052
Package: Microsoft.DesktopAppInstaller v1.12.11692.0

Any other software? None

[jedieaston]

The file path is an implementation detail of the community repo, I don't think it's supposed to be true of all scenarios you use a manifest in (winget will install from any folder as long as it finds enough data in the yaml files).

[Trenly]

That does make sense, I did not consider that some people may not use winget-create. Although, if manifests are being validated, there is an extremely high likelihood it is for the public repository. Perhaps a warning would be beneficial? That way if a user is validating before a pull request they get warned about a mismatch (assuming the file path starts at ~/manifests) while still allowing those who are not working out of their manifests directory tree to continue validation

I would think, though, that the file names should still be checked in validation. Maybe a warning is appropriate for that also