search

microsoft / winget-cli

WinGet is the Windows Package Manager. This project includes a CLI (Command Line Interface), PowerShell modules, and a COM (Component Object Model) API (Application Programming Interface).
https://learn.microsoft.com/windows/package-manager/
MIT License
23.08k stars 1.44k forks source link

`winget upgrade` status message. App installed but no upgrade available. #2159

Open JohnLukeBentley opened 2 years ago

JohnLukeBentley commented 2 years ago

Description of the new feature / enhancement

I suggest the winget upgrade status messages be more informative when the app is installed but no upgrade is available.

Proposed technical implementation details

The current behaviour.

Assume Foobar is not is installed on the machine (and not available). Then winget upgrade [app] produces the following, which is fine:

> winget upgrade foobar
No installed package found matching input criteria.

Assume Signal is installed and an upgrade is available. Then winget upgrade [app] produces the following, which is fine:

> winget upgrade signal
Found Signal [OpenWhisperSystems.Signal] Version 5.43.0
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://updates.signal.org/desktop/signal-desktop-win-5.43.0.exe
  ██████████████████████████████   116 MB /  116 MB
Successfully verified installer hash
Starting package install...
Successfully installed

Assume Signal is installed and an upgrade is not available. Then winget upgrade [app] produces the following

> winget upgrade signal
No applicable update found.

This messages is ambiguous.

Suggestion

I suggest something like the following less ambiguous message 

> winget upgrade signal
No update found. Found Signal [OpenWhisperSystems.Signal] Version 5.43.0. You are on the latest version.
bugrasan commented 2 years ago

i can confirm the issue with Microsoft.WindowsTerminal; why i had uninstalled the apps, and now can't install it again:

> winget search windowsterminal
Name                     Id                                Version      Source
-------------------------------------------------------------------------------
Windows Terminal Preview Microsoft.WindowsTerminal.Preview 1.13.10734.0 winget
Windows Terminal         Microsoft.WindowsTerminal         1.12.10983.0 winget

> winget install Microsoft.WindowsTerminal
No applicable installer found; see logs for more details.

> winget install Microsoft.WindowsTerminal -s winget
No applicable installer found; see logs for more details.
denelon commented 2 years ago

@bugrasan

Take a look at:

You might be affected by this one if you're on Windows 10. You can install an earlier version and winget show Microsoft.WindowsTerminal --versions will give you the list of available versions.

Trenly commented 1 year ago

[Policy] Command-Upgrade [Policy] Area-Output