Error upgrading with package id

kiddliu commented 2 years ago

Brief description of your issue

Not sure if it's related to the package Everything, an unexpected result is that winget upgrade voidtools.Everything shows No applicable update found. but winget upgrade listed this update.

Steps to reproduce

PS C:\Users\ziok_> winget upgrade
Name                        Id                   Version      Available
------------------------------------------------------------------------
Everything 1.4.1.1009 (x64) voidtools.Everything < 1.4.1.1014 1.4.1.1017
1 upgrades available.
PS C:\Users\ziok_> winget upgrade voidtools.Everything
No applicable update found.
PS C:\Users\ziok_> winget upgrade --all --silent
Name                        Id                   Version      Available
------------------------------------------------------------------------
Everything 1.4.1.1009 (x64) voidtools.Everything < 1.4.1.1014 1.4.1.1017
1 upgrades available.

(1/1) Found Everything [voidtools.Everything] Version 1.4.1.1017
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://www.voidtools.com/Everything-1.4.1.1017.x64.msi
  ██████████████████████████████  1.84 MB / 1.84 MB
Successfully verified installer hash
Starting package install...
Successfully installed

Expected behavior

It should work as expected, upgrade the package with the specified Id.

Actual behavior

It shows No applicable update found.

Environment

Windows Package Manager (Preview) v1.4.2011-preview
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.25163.1010
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.19.2011.0

Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Trenly commented 2 years ago

Interesting; When I use winget list voidtools.everything I see the same - that a newer version is available. But, when I try winget upgrade, it doesn't detect it for upgrade at all, regardless of if I'm listing available upgrades, upgrading with --all, or using the package ID

I think it is an issue with disambiguating between voidtools.Everything and voidtools.Everything.Lite and voidtools.Everything.Alpha

2022-07-28 12:44:55.018 [REPO] Found multiple matches for installed package [Everything] in source [Microsoft.Winget.Source_8wekyb3d8bbwe] when searching for [Query:[none] Include:ProductCode='everything'[Exact] Include:NormalizedNameAndPublisher='everything'+'voidtools'[Exact]]
|
|
2022-07-28 12:44:55.020 [REPO]   Checking match with package id: voidtools.Everything
2022-07-28 12:44:55.020 [REPO]   Appropriate available package could not be determined

yao-msft commented 2 years ago

I think it is an issue with disambiguating between voidtools.Everything and voidtools.Everything.Lite and voidtools.Everything.Alpha

In that case, I think winget upgrade voidtools.Everything -e would work.

Trenly commented 2 years ago

I think this might be a bigger issue, actually. I was testing a different bug for pkgs, and I noticed that Firefox wasn't being selected for upgrade, but when I list the package by itself or upgrade by itself, then it is detected properly. Unless it's entirely unrelated, which could be possible . . .

v1.4 client output

``` PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs> winget list Mozilla Name Id Version --------------------------------------------------------------------- Mozilla Firefox (x64 en-US) Mozilla Firefox 102.0 (x64 en-US) 102.0 Mozilla Maintenance Service MozillaMaintenanceService 102.0 PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs> winget list Mozilla.Firefox Name Id Version Available Source -------------------------------------------------------------------- Mozilla Firefox (x64 en-US) Mozilla.Firefox 102.0 103.0 winget PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs> winget upgrade Name Id Version Available Source -------------------------------------------------------------- Microsoft Edge Microsoft.Edge 92.0.902.67 103.0.1264.71 winget 1 upgrades available. PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs> winget upgrade --all Name Id Version Available Source -------------------------------------------------------------- Microsoft Edge Microsoft.Edge 92.0.902.67 103.0.1264.71 winget 1 upgrades available. PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs> winget upgrade Mozilla.Firefox Found Mozilla Firefox [Mozilla.Firefox] Version 103.0 This application is licensed to you by its owner. Microsoft is not responsible for, nor does it grant any licenses to, third-party packages. Downloading https://download-installer.cdn.mozilla.net/pub/firefox/releases/103.0/win64/en-US/Firefox%20Setup%20103.0.exe ██████████████████████████████ 53.3 MB / 53.3 MB Successfully verified installer hash Starting package install... Successfully installed PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs> winget --info Windows Package Manager (Preview) v1.4.2011-preview Copyright (c) Microsoft Corporation. All rights reserved. Windows: Windows.Desktop v10.0.19041.1826 System Architecture: X64 Package: Microsoft.DesktopAppInstaller v1.19.2011.0 Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir Links --------------------------------------------------------------------------- Privacy Statement https://aka.ms/winget-privacy License Agreement https://aka.ms/winget-license Third Party Notices https://aka.ms/winget-3rdPartyNotice Homepage https://aka.ms/winget Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs> ```

v1.2 client output

``` PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs> winget list mozilla Name Id Version --------------------------------------------------------------------- Mozilla Firefox (x64 en-US) Mozilla Firefox 102.0 (x64 en-US) 102.0 Mozilla Maintenance Service MozillaMaintenanceService 102.0 PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs> winget list mozilla.firefox Name Id Version Available Source -------------------------------------------------------- Mozilla Firefox Mozilla.Firefox 102.0 103.0 winget PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs> winget upgrade Name Id Version Available Source -------------------------------------------------------------- Microsoft Edge Microsoft.Edge 92.0.902.67 103.0.1264.71 winget 1 upgrades available. PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs> winget upgrade --all No applicable update found. PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs> winget upgrade mozilla.firefox Found Mozilla Firefox [Mozilla.Firefox] Version 103.0 This application is licensed to you by its owner. Microsoft is not responsible for, nor does it grant any licenses to, third-party packages. Downloading https://download-installer.cdn.mozilla.net/pub/firefox/releases/103.0/win64/en-US/Firefox%20Setup%20103.0.exe ██████████████████████████████ 53.3 MB / 53.3 MB Successfully verified installer hash Starting package install... Successfully installed PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs> winget --info Windows Package Manager v1.2.10271 Copyright (c) Microsoft Corporation. All rights reserved. Windows: Windows.Desktop v10.0.19041.1826 Package: Microsoft.DesktopAppInstaller v1.17.10271.0 Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir Links --------------------------------------------------------------------------- Privacy Statement https://aka.ms/winget-privacy License Agreement https://aka.ms/winget-license Third Party Notices https://aka.ms/winget-3rdPartyNotice Homepage https://aka.ms/winget Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs> ```

[v1.2 Logs - Standard.zip](https://github.com/microsoft/winget-cli/files/9213351/v1.2.Logs.-.Standard.zip)

JohnMcPMS commented 2 years ago

I think this might be a bigger issue, actually. I was testing a different bug for pkgs, and I noticed that Firefox wasn't being selected for upgrade, but when I list the package by itself or upgrade by itself, then it is detected properly.

That sounds like the opposite of the OP though...

Trenly commented 2 years ago

I think this might be a bigger issue, actually. I was testing a different bug for pkgs, and I noticed that Firefox wasn't being selected for upgrade, but when I list the package by itself or upgrade by itself, then it is detected properly.

That sounds like the opposite of the OP though...

Hmm. That is true. Opposite, but related possibly?

microsoft / winget-cli