search

microsoft / winget-cli

WinGet is the Windows Package Manager. This project includes a CLI (Command Line Interface), PowerShell modules, and a COM (Component Object Model) API (Application Programming Interface).
https://learn.microsoft.com/windows/package-manager/
MIT License
23.28k stars 1.45k forks source link

ShellExecute installer failed: 3010 despite this being marked as a success code. #3911

Open FaserF opened 12 months ago

FaserF commented 12 months ago

Brief description of your issue

InstallerSuccessCodes:

This is definied in the XML here: https://github.com/microsoft/winget-pkgs/pull/123504

Unfortunatly the installer fails instead of marking it as successfull. This looks like a bug.

Steps to reproduce

Install the new package from here: https://github.com/microsoft/winget-pkgs/pull/123504

Expected behavior

Installation being marked as successfull

Actual behavior

Installations is being marked as failed

Environment

Windows-Paket-Manager v1.6.3133
Copyright (c) Microsoft Corporation. Alle Rechte vorbehalten.

Windows: Windows.Desktop v10.0.22621.2715
Systemarchitektur: X64
Paket: Microsoft.DesktopAppInstaller v1.21.3133.0
denelon commented 11 months ago

It might be better to map this to an "expected return code" rather than a success code. That way the user will be informed a reboot is required.