search

microsoft / winget-cli

WinGet is the Windows Package Manager. This project includes a CLI (Command Line Interface), PowerShell modules, and a COM (Component Object Model) API (Application Programming Interface).
https://learn.microsoft.com/windows/package-manager/
MIT License
23.1k stars 1.44k forks source link

GitHub.GitHubDesktop doesn't actually install GitHub Desktop #426

Closed latere-a-latere closed 2 years ago

latere-a-latere commented 4 years ago

Just tried installing this package and after a few minutes of being confused as I didn't find any new shortcuts in my start menu, I found out that all it did was unpack the GitHub Desktop installer in C:\Program Files (x86)\GitHub Desktop Installer. I had to run this application by hand in order to actually get GitHub Desktop installed.

Using a clean copy of the Win10 Dev VM, build 1909.

superusercode commented 4 years ago

does it work the same way as the teams machine-wide installer?

e.g. restarting will install github desktop

if this isn't ideal there is an exe installer that I assume uses nullsoft since it uses the /s flag https://chocolatey.org/packages/github-desktop#files

superusercode commented 4 years ago

image it is technically a successful install, but i assume the exe would work better

latere-a-latere commented 4 years ago

It requires a reboot to actually trigger the installer? I do feel like that's bad UX, especially since it doesn't even tell the user about any of this.

Using the exe installer seems like a much better idea.

latere-a-latere commented 4 years ago

Looks like the exe doesn't run silently entirely using /S and launches the application post-install. Checked the installer using USSF and it doesn't seem to be using NSIS - Will try a few more switches to see what works.

latere-a-latere commented 4 years ago

Just ran choco install github-desktop, turns out their install isn't silent either. After some google-fu it turns out that the exe installer is a ClickOnce installer which does not support unattended installations.

This means that for now, this is the best "experience" we're going to get using the msi installer, unless we're prepared to make an exception and allow GitHub Desktop to open up after installation. If we decide to keep everything as it is then I propose we change the package name to GitHub.GitHubDesktopInstaller or mention the reboot requirement in the description.

denelon commented 4 years ago

I'm going to go ahead and move this to the client repository. It looks like we need to do some work around installers that require reboot, and or some better messaging in the client.

vedantmgoyal9 commented 2 years ago

I guess this is fixed now, I'm able to install github desktop.

@denelon

hueldoeu commented 5 months ago

winget upgrade GitHub.GitHubDesktop doesn't work either. i use this way https://docs.github.com/en/desktop/installing-and-authenticating-to-github-desktop/updating-github-desktop

bronthulke commented 3 months ago

I've just had the same issue with winget, as well - I installed it via Dev Home and it just unpacked the installer to C:\Program Files (x86)\GitHub Desktop Deployment and then seemingly stopped.

hueldoeu commented 2 months ago

i think it got fixed now.