Open CN-traveler opened 2 years ago
Well, the fix would be to change the PackageIdentifier
from huanghongxun.HelloMinecraft!Launcher
to huanghongxun.HelloMinecraftLauncher
as Windows does not allow !
in the Path.
I can't recall but hopefully the pipelines does not allow special characters as that would break alot of stuff. Should probably be double checked in both WinGet Create and YamlCreate @denelon @Trenly
Should probably be double checked in both WinGet Create and YamlCreate
YamlCreate will allow !
in the package Identifier, but I would suggest that this is actually an issue with the schema, as that is what both WingetCreate and YamlCreate use to validate
@ryfu-msft do we need to look at how we're validating?
Please confirm these before moving forward
Category of the issue
Other
Brief description of your issue
I encountered this error when creating a new application package manifest. It does not allow exclamation marks in the path. However, there is no restriction on this in the matching rules of the schemas.
Steps to reproduce
create manifests
manifests\h\huanghongxun\HelloMinecraft!Launcher\3.5.3.221\huanghongxun.HelloMinecraft!Launcher.installer.yaml
manifests\h\huanghongxun\HelloMinecraft!Launcher\3.5.3.221\huanghongxun.HelloMinecraft!Launcher.locale.zh-CN.yaml
manifests\h\huanghongxun\HelloMinecraft!Launcher\3.5.3.221\huanghongxun.HelloMinecraft!Launcher.yaml
winget install
Actual behavior
Expected behavior
no error
Environment
Screenshots and Logs