search

microsoft / winget-cli

WinGet is the Windows Package Manager. This project includes a CLI (Command Line Interface), PowerShell modules, and a COM (Component Object Model) API (Application Programming Interface).
https://learn.microsoft.com/windows/package-manager/
MIT License
23.37k stars 1.45k forks source link

Fix grammatical issues in Bug Report.yml, and Update dependencies #4788

Closed skanda890 closed 2 months ago

skanda890 commented 2 months ago

Summary of the PR

Update dependencies and more.

Microsoft Reviewers: Open in CodeFlow
github-actions[bot] commented 2 months ago

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

Unrecognized words (1)

whitesource

Previously acknowledged words that are now absent AKV Asn azcopy cobertura Peet REINSTALLMODE sas SASURL 🫥
To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands ... in a clone of the [git@github.com:skanda890/Winget-Cli.git](https://github.com/skanda890/Winget-Cli.git) repository on the `master` branch ([:information_source: how do I use this?]( https://github.com/check-spelling/check-spelling/wiki/Accepting-Suggestions)): ``` sh curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.22/apply.pl' | perl - 'https://github.com/microsoft/winget-cli/actions/runs/10701892874/attempts/1' ```
Errors (1) See the [:open_file_folder: files](https://github.com/microsoft/winget-cli/pull/4788/files/) view, the [:scroll:action log](https://github.com/microsoft/winget-cli/actions/runs/10701892874/job/29668822940#step:4:1), or [:memo: job summary](https://github.com/microsoft/winget-cli/actions/runs/10701892874/attempts/1#summary-29668822940) for details. [:x: Errors](https://github.com/check-spelling/check-spelling/wiki/Event-descriptions) | Count -|- [:x: check-file-path](https://github.com/check-spelling/check-spelling/wiki/Event-descriptions#check-file-path) | 1 See [:x: Event descriptions](https://github.com/check-spelling/check-spelling/wiki/Event-descriptions) for more information.
If the flagged items are :exploding_head: false positives If items relate to a ... * binary file (or some other file you wouldn't want to check at all). Please add a file path to the `excludes.txt` file matching the containing file. File paths are Perl 5 Regular Expressions - you can [test]( https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your files. `^` refers to the file's path from the root of the repository, so `^README\.md$` would exclude [README.md]( ../tree/HEAD/README.md) (on whichever branch you're using). * well-formed pattern. If you can write a [pattern]( https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples:-patterns ) that would match it, try adding it to the `patterns.txt` file. Patterns are Perl 5 Regular Expressions - you can [test]( https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your lines. Note that patterns can't match multiline strings.
denelon commented 2 months ago

I'll need to have an engineer check Mend Bolt out before merging this PR.

skanda890 commented 2 months ago

URL for Mend Bolt:https://www.mend.io/free-developer-tools/bolt

JohnMcPMS commented 2 months ago

We already have internal infrastructure that handles the same type of reporting that Mend Bolt appears to be doing, and it is required that we leverage it. I would prefer not to add a 3rd party action (mild risk) that does the same (no apparent gain).

skanda890 commented 2 months ago

But after using Mend Bolt for some time with other apps like Mend Bolt, I feel like Mend Bolt is better and is the best out of all.

denelon commented 2 months ago

@skanda890 I can appreciate the familiarity with other tools and the things they provide. Rather than adding another layer of complexity which comes with potential performance limitations (5 calls / day with Mind Bolt) and the potential for other complex interactions, I'd ask what Mind Bolt is doing that we're not doing with our internal tooling to see if we can cover differences that way.

Given the response from our engineering team, I would not merge this PR and add Mind Bolt.

skanda890 commented 2 months ago

What service do you use? If I get this I can compare the features between them.

denelon commented 2 months ago

It's an internal set of tools. They are designed to ensure we're complying with all of our company policies. The bigger question I'd ask is what value does the tool you proposed provide? Let's assume the software vulnerability detection is handled by the tooling we use today.

skanda890 commented 2 months ago

Okay, leave that, what about the other things?

denelon commented 2 months ago

@skanda890 PRs should focus on a "single" change or request. That means keeping them to "one" logical topic and have a single issue they resolve. Continuing to modify the PR causes churn.

I'd also suggest making PRs as draft until they are actually ready for review to be merged.

The images for the icons will not be accepted as these are the official images. Any changes run the risk of changing how they are displayed as the image formats are not lossless.

We love the enthusiasm and welcome improvements, but it's hard to reason about unrelated changes. Smaller PRs are easier to fully understand and review, which means they are more likely to get merged.

yao-msft commented 2 months ago

/azp run

azure-pipelines[bot] commented 2 months ago
Azure Pipelines successfully started running 1 pipeline(s).
skanda890 commented 2 months ago

@yao-msft, I have made some changes. Kindly review them.

skanda890 commented 2 months ago

The changes for Microsoft.Posershell.SDK should be a separate pull request. It is best to keep each pull request limited to a single set of similar changes instead of grouping multiple changes into a single PR

To: @Trenly

🌟 Ode to My PR Mishap 🌟

Oh, tangled branches of my git tree, How thou dost vex me with thy entwined changes! Forgive me, dear reviewer, for my folly, As I seek redemption in separate PRs.

Let each branch stand alone, proud and distinct, Like constellations in the midnight sky. And may our codebase sing harmoniously, Free from the cacophony of tangled diffs.

@Trenly, grant me this chance— To untangle my commits, like a patient weaver, Crafting a quilt of elegance and clarity.

In this digital realm, where bits converge, Let our apologies be sincere, our PRs pristine.

denelon commented 2 months ago

This is the first PR poetry I've ever heard of!

skanda890 commented 2 months ago

Do you guys have any tips on where to contribute or any open repositories where I can contribute?

denelon commented 2 months ago

It really depends on what your "goal" is. It could be better to go a bit deeper into code on a smaller number of projects rather than to scatter across a larger number of projects. Every project is going to have its own community and set of standards. There are lots of different ways to contribute as well. Sometimes just doing work on documentation adds massive value, other times it might be fixing bugs or adding features. It just depends on why you're wanting to contribute.

skanda890 commented 2 months ago

It really depends on what your "goal" is. It could be better to go a bit deeper into code on a smaller number of projects rather than to scatter across a larger number of projects. Every project is going to have its own community and set of standards. There are lots of different ways to contribute as well. Sometimes just doing work on documentation adds massive value, other times it might be fixing bugs or adding features. It just depends on why you're wanting to contribute.

My goal is just to contribute to an open repository.