search

microsoft / winget-cli

WinGet is the Windows Package Manager. This project includes a CLI (Command Line Interface), PowerShell modules, and a COM (Component Object Model) API (Application Programming Interface).
https://learn.microsoft.com/windows/package-manager/
MIT License
23.35k stars 1.45k forks source link

Change meaning of AddOrUpdate return bool #4885

Closed JohnMcPMS closed 1 month ago

JohnMcPMS commented 1 month ago

Issue

The requestor of this new (1.10) API needs to know whether the operation was an add or an update. At the same time, the "was the index modified" return value from Update has always been true for any changes since the manifest hash was added.

Change

Return true when adding and false when updating.

Validation

Updated the unit tests to reflect this semantic shift.

Microsoft Reviewers: Open in CodeFlow
msftrubengu commented 1 month ago

So picky this requestor

JohnMcPMS commented 1 month ago

So picky this requestor

J'accuse