microsoft / winget-create

The Windows Package Manager Manifest Creator command-line tool (aka wingetcreate)
MIT License
492 stars 84 forks source link

wingetcreate 1.1.2.0 produces manifiests rejected by WinGetSvc-Validation #297

Closed pedrolcl closed 2 years ago

pedrolcl commented 2 years ago

Brief description of your issue

A PR for my updated app has been rejected because:

Please verify the manifest file is compliant with the package manager 1.0 manifest specification.

The manifest has been created with wingetcreate.exe v1.1.2.0 with this command line:

wingetcreate.exe update --urls https://sourceforge.net/projects/dmidiplayer/files/v1.7.0/dmidiplayer-1.7.0-win-x64-setup.exe/download --version 1.7.0 Drumstick.dmidiplayer

The manifests use the schema https://aka.ms/winget-manifest.installer.1.2.0.schema.json which is certainly not the 1.1 schema

Steps to reproduce

use the latest wingetcreate.exe to update an existing manifest, and it will use an schema that will be rejected by the automatic validation when included in a merge request.

Expected behavior

wingetcreate.exe should use a schema that is accepted by winget

Actual behavior

The manifests created by wingetcreate.exe are being rejected by winget

Environment

winget --info
Administrador de paquetes de Windows v1.3.2091
Copyright (c) Microsoft Corporation. Todos los derechos reservados.

Windows: Windows.Desktop v10.0.19044.1826
Arquitectura del sistema: X64
Paquete: Microsoft.DesktopAppInstaller v1.18.2091.0
Trenly commented 2 years ago

See microsoft/winget-pkgs#68845

Validation for the new schema will likely be enabled in just a few days, at which point all failing PR's will be rerun

denelon commented 2 years ago

FYI, I'm aiming to open up 1.2 schema validation in the community repository tomorrow (EOD).

denelon commented 2 years ago

We hit a snag. It's looking more like the end of the week. We will get it out ASAP.

ryfu-msft commented 2 years ago

We have opened up 1.2 schema validation in the community repository. Closing this issue as it has now been resolved.