Don't fail on exe's without embedded xml manifests

microsoft / winget-create

The Windows Package Manager Manifest Creator command-line tool (aka wingetcreate)

MIT License

491 stars 84 forks source link

Don't fail on exe's without embedded xml manifests #334

Closed josh-hemphill closed 1 year ago

josh-hemphill commented 1 year ago

[x] Have you signed the Contributor License Agreement?
[x] Are you working against an Issue?

potentially closes #302

There are lots of tools and applications who's executables don't use embedded xml manifests, and only use the standard windows file properties.

e.g. deno

I'm not a huge fan of how I did it, expecting an error, but I couldn't find any utility in the library being used to test for the existence of the manifest first.

Microsoft Reviewers: Open in CodeFlow

josh-hemphill commented 1 year ago

@microsoft-github-policy-service agree

ryfu-msft commented 1 year ago

/azp run

azure-pipelines[bot] commented 1 year ago

Azure Pipelines successfully started running 1 pipeline(s).