search

microsoft / winget-create

The Windows Package Manager Manifest Creator command-line tool (aka wingetcreate)
MIT License
491 stars 84 forks source link

Failed to parse package hosted on Github #336

Closed Masamune3210 closed 1 year ago

Masamune3210 commented 1 year ago

Brief description of your issue

Trying to add https://github.com/BakasuraRCE/abgx360/releases/download/v1.0.6-and-v1.0.2/windows_abgx360_v1.0.6_setup.exe to the repo but wingetcreate keeps saying that it failed to parse the package

Steps to reproduce

Try to create a manifest using https://github.com/BakasuraRCE/abgx360/releases/download/v1.0.6-and-v1.0.2/windows_abgx360_v1.0.6_setup.exe as the source

Expected behavior

Package is downloaded and parsed correctly

Actual behavior

Failed to parse the package from [https://github.com/BakasuraRCE/abgx360/releases/download/v1.0.6-and-v1.0.2/windows_abgx360_v1.0.6_setup.exe]

Environment

Windows Package Manager (Preview) v1.4.3132-preview
Windows: Windows.Desktop v10.0.22621.963
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.19.3132.0
Trenly commented 1 year ago

I believe it is because the exe file doesn't have a manifest embedded in it (according to ResourceHacker).

Might be related to https://github.com/microsoft/winget-create/pull/334

Masamune3210 commented 1 year ago

Hmm, you might be right

ryfu-msft commented 1 year ago

I tried this out with the new changes from #334. WingetCreate can successfully parse this package but there's no default/suggested fields since there's no manifest resource that we can use to pre-populate those fields. I am closing this issue since there's no longer a failure.