Problem updating existing manifest with more urls. - Githubissues

microsoft / winget-create

The Windows Package Manager Manifest Creator command-line tool (aka wingetcreate)

MIT License

490 stars 84 forks source link

Problem updating existing manifest with more urls. #351

Open Scavy opened 1 year ago

Scavy commented 1 year ago

Brief description of your issue

When having an existing manifest that has been approved, it seems impossible to add more installers and/or languages.

Steps to reproduce

wingetcreate update IDMComputerSolutions,Inc.UEStudio --urls https://downloads.ultraedit.com/main/ues/win/ues_english.exe https://downloads.ultraedit.com/main/ues/win/ues_english_64.exe https://downloads.ultraedit.com/main/ues/win/ues_german.exe https://downloads.ultraedit.com/main/ues/win/ues_german_64.exe https://downloads.ultraedit.com/main/ues/win/ues_italian.exe https://downloads.ultraedit.com/main/ues/win/ues_italian_64.exe https://downloads.ultraedit.com/main/ues/win/ues_spanish.exe https://downloads.ultraedit.com/main/ues/win/ues_spanish_64.exe https://downloads.ultraedit.com/main/ues/win/ues_french.exe https://downloads.ultraedit.com/main/ues/win/ues_french_64.exe https://downloads.ultraedit.com/main/ues/win/ues_portuguese.exe https://downloads.ultraedit.com/main/ues/win/ues_portuguese_64.exe https://downloads.ultraedit.com/main/ues/win/ues_japanese.exe https://downloads.ultraedit.com/main/ues/win/ues_japanese_64.exe https://downloads.ultraedit.com/main/ues/win/ues_korean.exe https://downloads.ultraedit.com/main/ues/win/ues_korean_64.exe https://downloads.ultraedit.com/main/ues/win/ues_chinese.exe https://downloads.ultraedit.com/main/ues/win/ues_chinese_64.exe https://downloads.ultraedit.com/main/ues/win/ues_chinese_traditional.exe https://downloads.ultraedit.com/main/ues/win/ues_chinese_traditional_64.exe https://downloads.ultraedit.com/main/ues/win/ues_english.msi https://downloads.ultraedit.com/main/ues/win/ues_english_64.msi https://downloads.ultraedit.com/main/ues/win/ues_german.msi https://downloads.ultraedit.com/main/ues/win/ues_german_64.msi https://downloads.ultraedit.com/main/ues/win/ues_italian.msi https://downloads.ultraedit.com/main/ues/win/ues_italian_64.msi https://downloads.ultraedit.com/main/ues/win/ues_spanish.msi https://downloads.ultraedit.com/main/ues/win/ues_spanish_64.msi https://downloads.ultraedit.com/main/ues/win/ues_french.msi https://downloads.ultraedit.com/main/ues/win/ues_french_64.msi https://downloads.ultraedit.com/main/ues/win/ues_portuguese.msi https://downloads.ultraedit.com/main/ues/win/ues_portuguese_64.msi https://downloads.ultraedit.com/main/ues/win/ues_japanese.msi https://downloads.ultraedit.com/main/ues/win/ues_japanese_64.msi https://downloads.ultraedit.com/main/ues/win/ues_korean.msi https://downloads.ultraedit.com/main/ues/win/ues_korean_64.msi https://downloads.ultraedit.com/main/ues/win/ues_chinese.msi https://downloads.ultraedit.com/main/ues/win/ues_chinese_64.msi https://downloads.ultraedit.com/main/ues/win/ues_chinese_traditional.msi https://downloads.ultraedit.com/main/ues/win/ues_chinese_traditional_64.msi

Expected behavior

It was expected to update the existing manifest via a PR.

Actual behavior

Wingetcreate gives the following error: Updating a manifest is only supported with the same number of installer URLs.

Environment

winget --info
Windows Package Manager v1.4.10173
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.19045.2673
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.19.10173.0

ryfu-msft commented 1 year ago

Hey @Scavy,

This issue is by design since we had intended for the update command to update only the existing installers that are currently present in the latest manifest version. If the number of installers provided is more than the existing number of installers, it makes it difficult to determine which installers should be updated with the provided installers.

I do think the update command needs to be extended to allow for additional installers to be added so something like wingetcreate update --add.

vikingnope commented 5 months ago

I have this issue, can anyone help?

mdanish-kh commented 5 months ago

@vikingnope That is related to https://github.com/microsoft/winget-create/issues/392

For now, updating the package in interactive mode should work

wingetcreate update orhun.git-cliff --version 2.1.2 --interactive

vikingnope commented 5 months ago

@mdanish-kh ah great thanks