[NestedPortable] wingetcreate fails to parse package

Brief description

As reported in microsoft/winget-pkgs#100719, there appears to be a number of nested portable installers that wingetcreate is failing to parse.

Steps to reproduce

Run

wingetcreate new https://github.com/fujiapple852/trippy/releases/download/0.7.0/trippy-0.7.0-x86_64-pc-windows-msvc.zip

Output

Downloading and parsing: https://github.com/fujiapple852/trippy/releases/download/0.7.0/trippy-0.7.0-x86_64-pc-windows-msvc.zip...
Failed to parse the package from [https://github.com/fujiapple852/trippy/releases/download/0.7.0/trippy-0.7.0-x86_64-pc-windows-msvc.zip]

Some other examples with the same outcome from the winget-pkgs repo:

BurntSushi.ripgrep.GNU: https://github.com/BurntSushi/ripgrep/releases/download/13.0.0/ripgrep-13.0.0-x86_64-pc-windows-gnu.zip
junegunn.fzf: https://github.com/junegunn/fzf/releases/download/0.39.0/fzf-0.39.0-windows_amd64.zip
sharkdp.fd: https://github.com/sharkdp/fd/releases/download/v8.7.0/fd-v8.7.0-i686-pc-windows-msvc.zip
Helm.Helm: https://get.helm.sh/helm-v3.10.1-windows-amd64.zip

Examples of nested portables that wingetcreate parses successfully from the winget-pkgs repo:

YSTYLE.kaf-cli: https://github.com/ystyle/kaf-cli/releases/download/v1.2.11/kaf-cli_v1.2.11_windows_386.zip
Gyan.FFmpeg: https://github.com/GyanD/codexffmpeg/releases/download/6.0/ffmpeg-6.0-full_build.zip
cURL.cURL: https://curl.se/windows/dl-7.85.0_9/curl-7.85.0_9-win64-mingw.zip

Some Debug Info

I tried to do a little big of debugging by building the client to see the error cause. I hope it's helpful info.

From the caller https://github.com/microsoft/winget-create/blob/2674058624005df4721080a369b23d1806cb6ee0/src/WingetCreateCore/Common/PackageParser.cs#L497

the execution fails in ParseExeInstallerType() at rc.LoadFrom(path) https://github.com/microsoft/winget-create/blob/2674058624005df4721080a369b23d1806cb6ee0/src/WingetCreateCore/Common/PackageParser.cs#L683

with Win32Exception Message = "The specified image file did not contain a resource section." NativeErrorCode = 1812

Since there isn't an explicit catch block for this exception, we return false with PackageParsing_Error

https://github.com/microsoft/winget-create/blob/2674058624005df4721080a369b23d1806cb6ee0/src/WingetCreateCore/Common/PackageParser.cs#L707-L718

https://github.com/microsoft/winget-create/blob/2674058624005df4721080a369b23d1806cb6ee0/src/WingetCreateCLI/Commands/NewCommand.cs#L201-L205

The code is external from Vestris.ResourceLib, and I could not find the .pdb file for the 2.1.0 version to debug it further. Because of being external, I think adding an explicit catch block for this error should be the fix here.

Environment

Windows Package Manager Manifest Creator v1.2.5.0

Copyright (c) Microsoft Corporation. All rights reserved.

The manifest creation command line utility generates manifest for submitting
apps to the Windows Package Manager repo.

  new         Launches a series of questions to help generate a new manifest
  update      Updates fields of an existing manifest
  submit      Submits a valid manifest directly to the Windows Package Manager repo
  settings    Open settings
  token       Modifies the GitHub auth token cache
  cache       Manage downloaded installers stored in cache

More help can be found at: https://aka.ms/winget-create
Privacy statement: https://aka.ms/privacy

microsoft / winget-create