microsoft / winget-create

The Windows Package Manager Manifest Creator command-line tool (aka wingetcreate)
MIT License
491 stars 84 forks source link

Update `cache` command to handle directories #360

Closed mdanish-kh closed 1 year ago

mdanish-kh commented 1 year ago

Motivation

The implementation of zip installers meant that winget-create now extracts the zip archives to %LOCALAPPDATA%\Temp\wingetcreate. The extracted directories are not shown in wingetcreate cache --list and not removed by wingetcreate cache --clean. This PR aims to fix the behavior by listing and removing the extracted folders in the respective wingetcreate cache commands.

Description


Microsoft Reviewers: Open in CodeFlow
ryfu-msft commented 1 year ago

/azp run

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 1 pipeline(s).
ryfu-msft commented 1 year ago

Ah I should have mentioned this before, you only need to edit the file src/WingetCreateCLI/Properties/Resources.resx. All of the other localized resx files will need to go through internal review and they will generate those files for us with the new changes. Please revert everything in Localization/Resources folder.

ryfu-msft commented 1 year ago

/azp run

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 1 pipeline(s).