Closed mdanish-kh closed 1 year ago
/azp run
Ah I should have mentioned this before, you only need to edit the file src/WingetCreateCLI/Properties/Resources.resx
. All of the other localized resx files will need to go through internal review and they will generate those files for us with the new changes. Please revert everything in Localization/Resources folder.
/azp run
Motivation
The implementation of zip installers meant that winget-create now extracts the zip archives to
%LOCALAPPDATA%\Temp\wingetcreate
. The extracted directories are not shown inwingetcreate cache --list
and not removed bywingetcreate cache --clean
. This PR aims to fix the behavior by listing and removing the extracted folders in the respectivewingetcreate cache
commands.Description
DirectoriesFound_Message
to show in cache --list/
or\
(depending on the OS)When deleting the directories, I used the same message for deleting installers i.e.,Renamed the existing resource string fromDeletingInstaller_Message
as I didn't feel the need to create a new string for it.DeletingInstaller_Message
->DeletingItem_Message
to be more generic to cater for deletion of directories as wellMicrosoft Reviewers: Open in CodeFlow