microsoft / winget-create

The Windows Package Manager Manifest Creator command-line tool (aka wingetcreate)
MIT License
489 stars 84 forks source link

CRLF line endings for all sources files #391

Closed sandercox closed 1 year ago

sandercox commented 1 year ago

Brief description of your issue

Trying to modify some code in the repo and doing a PR was almost impossible to get just my change to show. The file I tried to edit had mixed line endings.

Steps to reproduce

Try and open src/WingetCreateCLI/PromptHelper.cs with VS code and add /remove a line, make a commit and see that hundreds of lines have changed.

Expected behavior

After making a change and saving according to editorconfig settings, only my change is in the diff.

Maybe add a github action to have a double check on this policy such that no bad line endings end up in the source afterwards.

Actual behavior

All lines are reformatted in a decent editor creating messy PRs

Environment

-