microsoft / winget-create

The Windows Package Manager Manifest Creator command-line tool (aka wingetcreate)
MIT License
489 stars 84 forks source link

Change LF line endings to CRLF in project files #418

Closed mdanish-kh closed 1 year ago

mdanish-kh commented 1 year ago

I just did

Find: (?<!\r)\n
Replace: \r\n

across the whole project.

I understand some files may be auto-generated and these changes may get reverted in a new commit. Let me know if there are any here and if they should be excluded. Just highlighting the number of offending files with this commit.


Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-create/pull/418&drop=dogfoodAlpha
mdanish-kh commented 1 year ago

I realized I could've probably done

dotnet format src\WingetCreateCLI.sln --no-restore (Ref: https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet-format)

to enforce the .editorconfig settings across the whole solution. But the resulting output for the line endings is the same for both operations. Just that the dotnet format adds an additional formatting fix for Program.cs. I've run the command and added changes from it in the new commit.

ryfu-msft commented 1 year ago

/azp run

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 1 pipeline(s).