This PR fixes a regression introduced with PR #415 where manifests generated for certain ZIP installers i.e., that have common NestedInstallerFiles in base manifest across each installer node were incorrect. The code before #415 worked with distinct relative file paths. In #415, the behavior was modified to use the whole NestedInstallerFile object instead of RelativeFilePaths only but the code was not updated to have distinct NestedInstallerFiles object added into baseInstaller. This PR fixes that behavior.
The previous tests didn't catch this bug. Added a new test case that covers this behavior.
Manifests to test with
Some examples to compare the behavior with current main branch build and this PR's build:
This PR fixes a regression introduced with PR #415 where manifests generated for certain ZIP installers i.e., that have common NestedInstallerFiles in base manifest across each installer node were incorrect. The code before #415 worked with distinct relative file paths. In #415, the behavior was modified to use the whole NestedInstallerFile object instead of RelativeFilePaths only but the code was not updated to have distinct NestedInstallerFiles object added into baseInstaller. This PR fixes that behavior.
The previous tests didn't catch this bug. Added a new test case that covers this behavior.
Manifests to test with
Some examples to compare the behavior with current main branch build and this PR's build:
Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-create/pull/419&drop=dogfoodAlpha