I went through some of the Spanish localized .resx file to find places where the meaning may not be clear or may have been misunderstood by the translator. I'd suggest the following changes to the original resource strings:
AppMoniker_KeywordDescription - We should add "moniker" to the list of terms that need to be translated consistently. Also, looking at winget-cli, we don't always translate "moniker". For example, some strings have the comment "id, name, and moniker are all named values in our context, and may benefit from not being translated."
Channel_KeywordDescription - We should add "channel" to the list of terms too. Though this one we do seem to translate
Custom_KeywordDescription - In Spanish "switches" got translated as "modifiers". I'm not sure if this is the right translation, but it makes me realize that "switch" is a very overloaded word. We should add "switches" to the list of terms to be safe.
The examples in PackageIdentifier_KeywordDescription and DefaultLocale_KeywordDescription have a different format, in one there is spaces around the pipes | and in the other there aren't. Like |this| and | this |. Would look nicer if we had consistency but I don't know how we could comment to ensure that.
PackageIdentifier_KeywordDescription - We should add a locked comment for Microsoft.VisualStudio. In Spanish they added a space after the period.
InstallerSha256_KeywordDescription - The English string is "The SHA256 installer hash" and in Spanish it is translated as "Hash del instalador SHA256", which I read more like "the hash of the SHA256 installer" than "the SHA256 hash of the installer". We should add the intended meaning in a comment.
InstallerUrl_HelpText - In English Url is lowercase, instead of uppercase (URL). The text makes it seem like we are using the URL to extract the metadata, but I think it'd be more accurate to say we're using the installer at that URL? I'd change the English string, and maybe clarify it in a comment.
InstallLocation_KeywordDescription - The ID says "install location" but the text says "installer location"
Interactive_KeywordDescription - "The interactive installer switches" can be interpreted as "the switches of the interactive installer" or "the installer switches which are interactive"; we should clarify in a comment. I'm also not sure if the meaning of "switches that make the installer run interactively" is clear without already knowing it.
Language_KeywordDescription - "overrides default language" is translated as "invalidates default language" in Spanish. Maybe we should clarify what "override" means in this context
ManifestValidationSucceeded_Message - This string has something that is replaced by a boolean value. The bool should also be localized if it isn't already, and if we can't maybe we should have two strings
Is there a difference between Moniker_KeywordDescription and AppMoniker_KeywordDescription?
NewCommand_Description - Not a suggestion for change but something I found interesting: In Spanish the "Enter" key name is translated as "Entrar" which does seem to be used, but I had only ever seen "Intro"
Protocols_KeywordDescription - This sentence ends with "provides a handler for", which the translator seems to have thought would be followed by more text (as in "provides a handler for X"). We should change the string or add a comment to clarify this means "for which the package provides a handler for".
Protocols_KeywordDescription - Shouldn't these be called URI schemes?
Sha256_KeywordDescription seems like a duplicate of InstallerSha256_KeywordDescription
SignatureSha256_KeywordDescription - This seems translated as "the [signature hash] of the [MSIX SHA256]" instead of "the [SHA256 hash] of the signature of the MSIX" which I think is what we intend?
Silent_KeywordDescription in Spanish has "switches" translated as "conmutadores" whereas other strings have it as "modificadores". We really should document this in Term Studio
Tags_KeywordDescription - Text is ambiguous between "list of search terms for additional packages" and "list of additional search terms for the package"; should clarify in comment as at least the Spanish translation picked the wrong one
PackageVersion_KeywordDescription - The example here uses yet another format in Spanish. We have | por ejemplo, X |, |por ejemplo, X| and | p. ej. X |. We should mention in the comment that they all should be the same
InstallerManifestPreview_Message - I'm not sure what this is supposed to mean but I'm sure the text is ambiguous
Some of my comments assume we have a list of terms we've shared with the loc team, but I don't remember if we actually have onboarded that..
Description of the new feature / enhancement
I went through some of the Spanish localized .resx file to find places where the meaning may not be clear or may have been misunderstood by the translator. I'd suggest the following changes to the original resource strings:
AppMoniker_KeywordDescription- We should add "moniker" to the list of terms that need to be translated consistently. Also, looking at winget-cli, we don't always translate "moniker". For example, some strings have the comment "id, name, and moniker are all named values in our context, and may benefit from not being translated."Channel_KeywordDescription- We should add "channel" to the list of terms too. Though this one we do seem to translateCustom_KeywordDescription- In Spanish "switches" got translated as "modifiers". I'm not sure if this is the right translation, but it makes me realize that "switch" is a very overloaded word. We should add "switches" to the list of terms to be safe.PackageIdentifier_KeywordDescriptionandDefaultLocale_KeywordDescriptionhave a different format, in one there is spaces around the pipes|and in the other there aren't. Like|this|and| this |. Would look nicer if we had consistency but I don't know how we could comment to ensure that.PackageIdentifier_KeywordDescription- We should add alockedcomment forMicrosoft.VisualStudio. In Spanish they added a space after the period.InstallerSha256_KeywordDescription- The English string is "The SHA256 installer hash" and in Spanish it is translated as "Hash del instalador SHA256", which I read more like "the hash of the SHA256 installer" than "the SHA256 hash of the installer". We should add the intended meaning in a comment.InstallerUrl_HelpText- In English Url is lowercase, instead of uppercase (URL). The text makes it seem like we are using the URL to extract the metadata, but I think it'd be more accurate to say we're using the installer at that URL? I'd change the English string, and maybe clarify it in a comment.InstallLocation_KeywordDescription- The ID says "install location" but the text says "installer location"Interactive_KeywordDescription- "The interactive installer switches" can be interpreted as "the switches of the interactive installer" or "the installer switches which are interactive"; we should clarify in a comment. I'm also not sure if the meaning of "switches that make the installer run interactively" is clear without already knowing it.Language_KeywordDescription- "overrides default language" is translated as "invalidates default language" in Spanish. Maybe we should clarify what "override" means in this contextManifestValidationSucceeded_Message- This string has something that is replaced by a boolean value. The bool should also be localized if it isn't already, and if we can't maybe we should have two stringsMoniker_KeywordDescriptionandAppMoniker_KeywordDescription?NewCommand_Description- Not a suggestion for change but something I found interesting: In Spanish the "Enter" key name is translated as "Entrar" which does seem to be used, but I had only ever seen "Intro"Protocols_KeywordDescription- This sentence ends with "provides a handler for", which the translator seems to have thought would be followed by more text (as in "provides a handler for X"). We should change the string or add a comment to clarify this means "for which the package provides a handler for".Protocols_KeywordDescription- Shouldn't these be called URI schemes?Sha256_KeywordDescriptionseems like a duplicate ofInstallerSha256_KeywordDescriptionSignatureSha256_KeywordDescription- This seems translated as "the [signature hash] of the [MSIX SHA256]" instead of "the [SHA256 hash] of the signature of the MSIX" which I think is what we intend?Silent_KeywordDescriptionin Spanish has "switches" translated as "conmutadores" whereas other strings have it as "modificadores". We really should document this in Term StudioTags_KeywordDescription- Text is ambiguous between "list of search terms for additional packages" and "list of additional search terms for the package"; should clarify in comment as at least the Spanish translation picked the wrong onePackageVersion_KeywordDescription- The example here uses yet another format in Spanish. We have| por ejemplo, X |,|por ejemplo, X|and| p. ej. X |. We should mention in the comment that they all should be the sameInstallerManifestPreview_Message- I'm not sure what this is supposed to mean but I'm sure the text is ambiguousSome of my comments assume we have a list of terms we've shared with the loc team, but I don't remember if we actually have onboarded that..
Proposed technical implementation details
No response