microsoft / winget-create

The Windows Package Manager Manifest Creator command-line tool (aka wingetcreate)
MIT License
498 stars 85 forks source link

Replace argument for removing a previous manifest #440

Closed mdanish-kh closed 1 year ago

mdanish-kh commented 1 year ago

Example PR made with --replace:

There doesn't seem to be a great way to make an option accept optional values. Followed the recommendations listed here: https://github.com/commandlineparser/commandline/issues/674


Microsoft Reviewers: Open in CodeFlow
mdanish-kh commented 1 year ago

I will be following up with a PR to have "replace" work automatically for vanity URLs provided this gets approved

ryfu-msft commented 1 year ago

/azp run

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 1 pipeline(s).
ryfu-msft commented 1 year ago

/azp run

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 1 pipeline(s).
ryfu-msft commented 1 year ago

@mdanish-kh , Once this PR gets checked, I will work on pulling in the new localized strings from this PR once they are generated and cutting a new release :)

mdanish-kh commented 1 year ago

@ryfu-msft Thanks, I do have a quick PR incoming after this (to address #72) but I don't mind if that can wait until the next release

ryfu-msft commented 1 year ago

@ryfu-msft Thanks, I do have a quick PR incoming after this (to address #72) but I don't mind if that can wait until the next release

I'm happy to wait for that since that will be a really nice addition