search

microsoft / winget-create

The Windows Package Manager Manifest Creator command-line tool (aka wingetcreate)
MIT License
477 stars 82 forks source link

Warn user when upgrading with fewer URLs #443

Open Trenly opened 10 months ago

Trenly commented 10 months ago

Description of the new feature / enhancement

Not sure if this is a bug or a feature, but there were PR's for GoLang.Go created with fewer installer nodes.

While there are times that using fewer nodes is expected, such as when architectures are discontinued, these situations are fairly rare and should either throw a warning or only be valid in the interactive flow

Proposed technical implementation details

No response

mdanish-kh commented 10 months ago

I think this is a case where the manifest was modified manually and later submitted through wingetcreate submit. wingetcreate update (both interactive and autonomous) only works when the number of new Installer Urls is the same as the number in the previous manifest (with the exception of msixbundles).

For this, we would need to query the repository in the submit flow and display a warning? / prompt user to really understand the consequences? Though I think the complete fix would be to handle it in https://github.com/microsoft/winget-pkgs/issues/92688 (since even if the user accepts the warning, there's no way for a mod to know unless you manually see the previous manifest)

Trenly commented 10 months ago

Ah, so this is really more related to

I assumed it was an issue with wingetcreate because the header said the manifests were created with wingetcreate