Fix pattern for getting same name files

mdanish-kh commented 9 months ago

[x] Have you signed the Contributor License Agreement?
[x] Are you working against an Issue?
- Resolves #333

Not sure why/how but the call to Path.ChangeExtension() incorrectly modifies the file name for some files. Instead of returning expected pattern Thunderbird%20Setup%20102.6.0* (for actual file name Thunderbird%20Setup%20102.6.0.msi), it returns Thunderbird%20Setup%20102.6.msi (truncating the '0' instead of the extension)

To fix this, manually concatenated the strings to form a matching pattern.

Validation

Run wingetcreate update Mozilla.Thunderbird --version 102.6.0 -i

1) Give URL: https://download-installer.cdn.mozilla.net/pub/thunderbird/releases/102.6.0/win64/en-US/Thunderbird%20Setup%20102.6.0.msi 2) Then: https://download-installer.cdn.mozilla.net/pub/thunderbird/releases/102.6.0/win64/en-GB/Thunderbird%20Setup%20102.6.0.msi 3) Then: https://download-installer.cdn.mozilla.net/pub/thunderbird/releases/102.6.0/win64/de/Thunderbird%20Setup%20102.6.0.msi

Microsoft Reviewers: Open in CodeFlow

ryfu-msft commented 9 months ago

/azp run

azure-pipelines[bot] commented 9 months ago

Azure Pipelines successfully started running 1 pipeline(s).

mdanish-kh commented 9 months ago

This just needs a re-run it seems

exspandsome commented 9 months ago

Ok tonrun on fresh win11..!?

man. 25. sep. 2023, 19:08 skrev Muhammad Danish @.***>:

This just needs a re-run it seems

— Reply to this email directly, view it on GitHub https://github.com/microsoft/winget-create/pull/455#issuecomment-1734150174, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQDX3BWLMNSWU7FJ6UTG2ATX4G3BRANCNFSM6AAAAAA5FFBNEA . You are receiving this because you are subscribed to this thread.Message ID: @.***>