Closed mdanish-kh closed 11 months ago
@ryfu-msft Can we get a new release shipped out after this PR? #453 seems to be affecting a lot of CI runners in the wild. Fortunately, the change didn't break any functionality but just that the CI runners exit with an exception and non-zero error code making the action show as "failed".
@ryfu-msft Can we get a new release shipped out after this PR? #453 seems to be affecting a lot of CI runners in the wild. Fortunately, the change didn't break any functionality but just that the CI runners exit with an exception and non-zero error code making the action show as "failed".
I will go ahead and cut a new release now before this PR gets checked in, since it will take some time for the strings to get localized. Thanks for calling that out 😄
just a couple nits for cleanup
I added the new lines that since I saw them being used in other comments. I went ahead and cleaned all of the other ones too
/azp run
Reference implementation taken from the wiki:
https://github.com/commandlineparser/commandline/wiki/Help-Localization
https://github.com/commandlineparser/commandline/blob/master/demo/ReadText.LocalizedDemo/LocalizableSentenceBuilder.cs
I modified the file to resolve any VS warnings
Microsoft Reviewers: Open in CodeFlow