microsoft / winget-create

The Windows Package Manager Manifest Creator command-line tool (aka wingetcreate)
MIT License
498 stars 85 forks source link

Support localization for parser messages #457

Closed mdanish-kh closed 11 months ago

mdanish-kh commented 1 year ago

Reference implementation taken from the wiki:

To localize the keywords "Required,Default" and the error messages, add the the string expressions of the class SentenceBuilder to the resource files.

I modified the file to resolve any VS warnings


Microsoft Reviewers: Open in CodeFlow
mdanish-kh commented 11 months ago

@ryfu-msft Can we get a new release shipped out after this PR? #453 seems to be affecting a lot of CI runners in the wild. Fortunately, the change didn't break any functionality but just that the CI runners exit with an exception and non-zero error code making the action show as "failed".

ryfu-msft commented 11 months ago

@ryfu-msft Can we get a new release shipped out after this PR? #453 seems to be affecting a lot of CI runners in the wild. Fortunately, the change didn't break any functionality but just that the CI runners exit with an exception and non-zero error code making the action show as "failed".

I will go ahead and cut a new release now before this PR gets checked in, since it will take some time for the strings to get localized. Thanks for calling that out 😄

mdanish-kh commented 11 months ago

just a couple nits for cleanup

I added the new lines that since I saw them being used in other comments. I went ahead and cleaned all of the other ones too

ryfu-msft commented 11 months ago

/azp run

azure-pipelines[bot] commented 11 months ago
Azure Pipelines successfully started running 1 pipeline(s).