Add info command to display key information

microsoft / winget-create

The Windows Package Manager Manifest Creator command-line tool (aka wingetcreate)

MIT License

477 stars 82 forks source link

Add info command to display key information #461

Closed mdanish-kh closed 8 months ago

mdanish-kh commented 8 months ago

[x] Have you signed the Contributor License Agreement?
[x] Are you working against an Issue?
- Resolves #460

This PR adds support for root options for the CLI and the following:

[x] Support for adding Table output. There were a couple of open-source options available but they weren't stylistically similar to how it is displayed in winget CLI.
[x] User setting to specify whether paths displayed should be anonymous. This change is for both paths displayed on info command and manifest location showed at the end for update command
[x] Help text for root options

@ryfu-msft Can you kindly create these short URLs if you approve of them ☺️

https://aka.ms/winget-create-license → https://github.com/microsoft/winget-create/blob/main/LICENSE https://aka.ms/winget-create-privacy → https://github.com/microsoft/winget-create/blob/main/PRIVACY.md https://aka.ms/winget-create-3rdPartyNotice → https://github.com/microsoft/winget-create/blob/main/NOTICE.txt

Microsoft Reviewers: Open in CodeFlow

mdanish-kh commented 8 months ago

I would've loved to keep --info but it looks like anything that I'll do to make that happen will involve me doing a very hacky implementation with the parser. And even then all edge cases may not be covered as was the case with wingetcreate foobar here

I know we should try to align with winget-cli as much as possible but if we can achieve the same end result by simply adding a wingetcreate info command instead, that may be an easier solution. That would also make it easier for testing so we could verify what is displayed. Thoughts?

Sounds good. This will also make it easier in future to implement some common options for all commands (e.g. --log , --open-logs that are mentioned in a couple of issues here) since Info will now be a child of BaseCommand class