microsoft / winget-create

The Windows Package Manager Manifest Creator command-line tool (aka wingetcreate)
MIT License
472 stars 83 forks source link

Improvements to replace argument #485

Closed mdanish-kh closed 7 months ago

mdanish-kh commented 7 months ago

Changes

Since there isn't good support from the parser library for handling option dependency (ref https://github.com/commandlineparser/commandline/issues/3), I had to handle this manually (i think it's okay since this is only applicable for update command and there could only ever be a handful of arguments that have dependency on --submit). Now we can decide if we want this to be a "warning" behavior or a "blocking" behavior. I decided to go with a blocking behavior since users are likely to cancel the running update command or run submit command with --replace afterwards if they actually meant to use the replace behavior. Having it fail early makes user quickly recognize mistake and re-run the command with or without --replace.


Microsoft Reviewers: Open in CodeFlow
ryfu-msft commented 7 months ago

/azp run

azure-pipelines[bot] commented 7 months ago
Azure Pipelines successfully started running 1 pipeline(s).
ryfu-msft commented 7 months ago

/azp run

azure-pipelines[bot] commented 7 months ago
Azure Pipelines successfully started running 1 pipeline(s).