Improve the MakeDSC script

microsoft / winget-create

The Windows Package Manager Manifest Creator command-line tool (aka wingetcreate)

MIT License

472 stars 83 forks source link

Improve the MakeDSC script #488

Closed Trenly closed 7 months ago

Trenly commented 7 months ago

[x] Have you signed the Contributor License Agreement?
[x] Are you working against an Issue?
- - Merges into #462
Addresses most of @mdanish-kh 's comments in #462
Throws custom error type for missing dependencies
Writes DSC schema header in output file
Removes regex for source by using the selected package directly
Allows selection of package by ID, Name, or Index
Allows skipping package selection in case of a bad query
Removes for-loop displaying the package output and uses the pipeline instead

cc @KevinLaMS

Microsoft Reviewers: Open in CodeFlow

ryfu-msft commented 7 months ago

@Trenly, can you move the location of this script to Tools/WingetCreateMakeDSC.ps1 instead of src/Prototype/WingetCreateMakeDSC.ps1. This doesn't really relate to WingetCreate right now so I'd like to keep it separate from the src folder. Everything else looks good to me 😄

Trenly commented 7 months ago

@Trenly, can you move the location of this script to Tools/WingetCreateMakeDSC.ps1 instead of src/Prototype/WingetCreateMakeDSC.ps1. This doesn't really relate to WingetCreate right now so I'd like to keep it separate from the src folder. Everything else looks good to me 😄

@ryfu-msft - I can, but I would rather let @KevinLaMS do that in his branch just to avoid any merge conflicts. This PR merges into his draft PR and not into Main

KevinLaMS commented 7 months ago

@Trenly @mdanish-kh @ryfu-msft Thank you so much for helping get this tool out.
@denelon Would you mind tweeting about the tool, letting people know it is an easy way to quickly create configuration files for winget apps?