microsoft / winget-create

The Windows Package Manager Manifest Creator command-line tool (aka wingetcreate)
MIT License
505 stars 86 forks source link

Use latest project dependencies #512

Closed vedantmgoyal9 closed 9 months ago

vedantmgoyal9 commented 9 months ago

@yao-msft @ryfu-msft @mdanish-kh

Microsoft Reviewers: Open in CodeFlow
yao-msft commented 9 months ago

For updating all the package dependencies, we may need some internal reviews to determine which versions to use. For example, we may prefer versions with long term support instead of the latest. We may need to do some e2e validation. And may need to check dependencies align with related other parts of winget.

vedantmgoyal9 commented 9 months ago

I hope it gets merged before the release which will be done as soon as support for 1.6..0 manifests will be added.

yao-msft commented 9 months ago

I hope it gets merged before the release which will be done as soon as support for 1.6..0 manifests will be added.

Is there a particular reason we need to use latest for 1.6 release?

vedantmgoyal9 commented 9 months ago

There are a few enhancements I plan to do with update command so that it can perform advanced installer-and-url matches, which will enable wingetcreate to be used in automation scenarios. Using latest libraries will be a great help, as many of the dependencies have breaking changes, and the documentation for old versions is hard to find, unless they have versioned documentation which is in track with the releases of the library.

yao-msft commented 9 months ago

There are a few enhancements I plan to do with update command so that it can perform advanced installer-and-url matches, which will enable wingetcreate to be used in automation scenarios. Using latest libraries will be a great help, as many of the dependencies have breaking changes, and the documentation for old versions is hard to find, unless they have versioned documentation which is in track with the releases of the library.

Ah, thanks for the explanation. Really sorry and unfortunately we kicked off release build right after Ryan merged the 1es pipeline fix. This will be winget 1.7. Or if it's strongly desired, we could make a 1.6 servicing release for this.

ryfu-msft commented 9 months ago

/azp run

azure-pipelines[bot] commented 9 months ago
Azure Pipelines successfully started running 1 pipeline(s).
ryfu-msft commented 9 months ago

There are a few enhancements I plan to do with update command so that it can perform advanced installer-and-url matches, which will enable wingetcreate to be used in automation scenarios. Using latest libraries will be a great help, as many of the dependencies have breaking changes, and the documentation for old versions is hard to find, unless they have versioned documentation which is in track with the releases of the library.

I kicked off a new release so that we can start supporting 1.6 manifests.

I can cut another release after we get this checked in. I am just wary of upgrading lots of dependencies all at once as I'm not sure what will break so I want to take our time with this.

vedantmgoyal9 commented 9 months ago

No problem. I also see the pipelines have failed at "run tests" step. Will take a look where is problem occurring.

vedantmgoyal9 commented 9 months ago

I've verified now that all tests pass (locally). Please re-run the pipelines.

ryfu-msft commented 9 months ago

/azp run

azure-pipelines[bot] commented 9 months ago
Azure Pipelines successfully started running 1 pipeline(s).
ryfu-msft commented 9 months ago

@vedantmgoyal2009, please resolve conflicts, then I'll run the pipeline again. The rest looks good to me

ryfu-msft commented 9 months ago

/azp run

azure-pipelines[bot] commented 9 months ago
Azure Pipelines successfully started running 1 pipeline(s).
ryfu-msft commented 9 months ago

/azp run

azure-pipelines[bot] commented 9 months ago
Azure Pipelines successfully started running 1 pipeline(s).
vedantmgoyal9 commented 9 months ago

Pipelines passed (@yao-msft @ryfu-msft)