search

microsoft / winget-create

The Windows Package Manager Manifest Creator command-line tool (aka wingetcreate)
MIT License
472 stars 83 forks source link

Cannot update if name of EXE file has changed inside ZIP #530

Open rakleed opened 2 months ago

rakleed commented 2 months ago

Brief description of your issue

wingetcreate cannot update if the name of the EXE file inside the ZIP has changed.

Steps to reproduce

wingetcreate update -u https://download.gigabyte.com/FileList/Utility/GCC_24.05.01.01.zip -v 24.05.01.01 GIGABYTE.GigabyteControlCenter

Expected behavior

Manifest successfully creates.

Actual behavior

Error: Nested installer not found in zip archive: GIGABYTE Control Center_2024_Mar_release_All_Setup_B24032901.exe. Please use the interactive mode to update this package.

Environment

Windows Package Manager Manifest Creator v1.6.1.0
Operating System: Microsoft Windows NT 10.0.22631.0
System Architecture: X64
Trenly commented 1 month ago

I'm pretty sure this is intended behavior based on the error message shown. If there are multiple EXE's inside the zip file, selecting the correct one for the update could be inaccurate. Perhaps if there is only one EXE inside it could be autodetected, and that would be a great feature request