search

microsoft / winget-dsc

MIT License
23 stars 14 forks source link

Add WhatIf support for DSC v3 #89

Closed Gijsreyn closed 1 week ago

Gijsreyn commented 2 weeks ago

This PR adds WhatIf support.

[!NOTE]
WhatIf support is currently not implemented in DSC v3, see issue.

Gijsreyn commented 2 weeks ago

@ryfu-msft If you have some time, you mind checking out this PR? I changed the logic to retrieve data when starting pip.exe and included DSCCapabilities field.

Gijsreyn commented 2 weeks ago

Tested locally. All tests passed. Can you trigger the pipeline?

ryfu-msft commented 2 weeks ago

Tested locally. All tests passed. Can you trigger the pipeline?

Looks like we checked in some changes causing merge conflicts. Can you resolve them and I'll kick off a rerun.

github-actions[bot] commented 2 weeks ago

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

Unrecognized words (3)

confrimation itsdangerouss whatif

These words are not needed and should be removed Toolpackage

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands ... in a clone of the [git@github.com:Gijsreyn/winget-dsc.git](https://github.com/Gijsreyn/winget-dsc.git) repository on the `whatif-support` branch ([:information_source: how do I use this?]( https://docs.check-spelling.dev/Accepting-Suggestions)): ``` sh curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.24/apply.pl' | perl - 'https://github.com/microsoft/winget-dsc/actions/runs/11695744300/attempts/1' ```
Pattern suggestions :scissors: (3) You could add these patterns to `.github/actions/spelling/patterns.txt`: ``` # Automatically suggested patterns # hit-count: 13 file-count: 5 # Compiler flags (?:^|[\t ,"'`=(])-[DPWXYLlf](?=[A-Z]{2,}|[A-Z][a-z]|[a-z]{2,}) # hit-count: 3 file-count: 1 # githubusercontent /[-a-z0-9]+\.githubusercontent\.com/[-a-zA-Z0-9?&=_\/.]* # hit-count: 2 file-count: 1 # GitHub SHAs (markdown) (?:\[`?[0-9a-f]+`?\]\(https:/|)/(?:www\.|)github\.com(?:/[^/\s"]+){2,}(?:/[^/\s")]+)(?:[0-9a-f]+(?:[-0-9a-zA-Z/#.]*|)\b|) ```
Notices (1) #### See the [:open_file_folder: files](https://github.com/microsoft/winget-dsc/pull/89/files/) view, the [:scroll:action log](https://github.com/microsoft/winget-dsc/actions/runs/11695744300/job/32571671008#step:4:1), or [:memo: job summary](https://github.com/microsoft/winget-dsc/actions/runs/11695744300/attempts/1#summary-32571671008) for details. [:information_source: Notices](https://docs.check-spelling.dev/Event-descriptions) | Count -|- [:information_source: candidate-pattern](https://docs.check-spelling.dev/Event-descriptions#candidate-pattern) | 5 See [:information_source: Event descriptions](https://docs.check-spelling.dev/Event-descriptions) for more information.
If the flagged items are :exploding_head: false positives If items relate to a ... * binary file (or some other file you wouldn't want to check at all). Please add a file path to the `excludes.txt` file matching the containing file. File paths are Perl 5 Regular Expressions - you can [test]( https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your files. `^` refers to the file's path from the root of the repository, so `^README\.md$` would exclude [README.md]( ../tree/HEAD/README.md) (on whichever branch you're using). * well-formed pattern. If you can write a [pattern](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples:-patterns) that would match it, try adding it to the `patterns.txt` file. Patterns are Perl 5 Regular Expressions - you can [test]( https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your lines. Note that patterns can't match multiline strings.
Gijsreyn commented 2 weeks ago

Should be good to go @ryfu-msft !

github-actions[bot] commented 2 weeks ago

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

Unrecognized words (4)

confrimation itsdangerouss pscustomobject whatif

These words are not needed and should be removed Toolpackage

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands ... in a clone of the [git@github.com:Gijsreyn/winget-dsc.git](https://github.com/Gijsreyn/winget-dsc.git) repository on the `whatif-support` branch ([:information_source: how do I use this?]( https://docs.check-spelling.dev/Accepting-Suggestions)): ``` sh curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.24/apply.pl' | perl - 'https://github.com/microsoft/winget-dsc/actions/runs/11695784649/attempts/1' ```
Pattern suggestions :scissors: (3) You could add these patterns to `.github/actions/spelling/patterns.txt`: ``` # Automatically suggested patterns # hit-count: 13 file-count: 5 # Compiler flags (?:^|[\t ,"'`=(])-[DPWXYLlf](?=[A-Z]{2,}|[A-Z][a-z]|[a-z]{2,}) # hit-count: 3 file-count: 1 # githubusercontent /[-a-z0-9]+\.githubusercontent\.com/[-a-zA-Z0-9?&=_\/.]* # hit-count: 2 file-count: 1 # GitHub SHAs (markdown) (?:\[`?[0-9a-f]+`?\]\(https:/|)/(?:www\.|)github\.com(?:/[^/\s"]+){2,}(?:/[^/\s")]+)(?:[0-9a-f]+(?:[-0-9a-zA-Z/#.]*|)\b|) ```
Notices (1) #### See the [:open_file_folder: files](https://github.com/microsoft/winget-dsc/pull/89/files/) view, the [:scroll:action log](https://github.com/microsoft/winget-dsc/actions/runs/11695784649/job/32571787959#step:4:1), or [:memo: job summary](https://github.com/microsoft/winget-dsc/actions/runs/11695784649/attempts/1#summary-32571787959) for details. [:information_source: Notices](https://docs.check-spelling.dev/Event-descriptions) | Count -|- [:information_source: candidate-pattern](https://docs.check-spelling.dev/Event-descriptions#candidate-pattern) | 5 See [:information_source: Event descriptions](https://docs.check-spelling.dev/Event-descriptions) for more information.
If the flagged items are :exploding_head: false positives If items relate to a ... * binary file (or some other file you wouldn't want to check at all). Please add a file path to the `excludes.txt` file matching the containing file. File paths are Perl 5 Regular Expressions - you can [test]( https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your files. `^` refers to the file's path from the root of the repository, so `^README\.md$` would exclude [README.md]( ../tree/HEAD/README.md) (on whichever branch you're using). * well-formed pattern. If you can write a [pattern](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples:-patterns) that would match it, try adding it to the `patterns.txt` file. Patterns are Perl 5 Regular Expressions - you can [test]( https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your lines. Note that patterns can't match multiline strings.
github-actions[bot] commented 2 weeks ago

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

Unrecognized words (1)

itsdangerouss

These words are not needed and should be removed Toolpackage

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands ... in a clone of the [git@github.com:Gijsreyn/winget-dsc.git](https://github.com/Gijsreyn/winget-dsc.git) repository on the `whatif-support` branch ([:information_source: how do I use this?]( https://docs.check-spelling.dev/Accepting-Suggestions)): ``` sh curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.24/apply.pl' | perl - 'https://github.com/microsoft/winget-dsc/actions/runs/11695815976/attempts/1' ```
Pattern suggestions :scissors: (3) You could add these patterns to `.github/actions/spelling/patterns.txt`: ``` # Automatically suggested patterns # hit-count: 13 file-count: 5 # Compiler flags (?:^|[\t ,"'`=(])-[DPWXYLlf](?=[A-Z]{2,}|[A-Z][a-z]|[a-z]{2,}) # hit-count: 3 file-count: 1 # githubusercontent /[-a-z0-9]+\.githubusercontent\.com/[-a-zA-Z0-9?&=_\/.]* # hit-count: 2 file-count: 1 # GitHub SHAs (markdown) (?:\[`?[0-9a-f]+`?\]\(https:/|)/(?:www\.|)github\.com(?:/[^/\s"]+){2,}(?:/[^/\s")]+)(?:[0-9a-f]+(?:[-0-9a-zA-Z/#.]*|)\b|) ```
Notices (1) #### See the [:open_file_folder: files](https://github.com/microsoft/winget-dsc/pull/89/files/) view, the [:scroll:action log](https://github.com/microsoft/winget-dsc/actions/runs/11695815976/job/32571865745#step:4:1), or [:memo: job summary](https://github.com/microsoft/winget-dsc/actions/runs/11695815976/attempts/1#summary-32571865745) for details. [:information_source: Notices](https://docs.check-spelling.dev/Event-descriptions) | Count -|- [:information_source: candidate-pattern](https://docs.check-spelling.dev/Event-descriptions#candidate-pattern) | 5 See [:information_source: Event descriptions](https://docs.check-spelling.dev/Event-descriptions) for more information.
If the flagged items are :exploding_head: false positives If items relate to a ... * binary file (or some other file you wouldn't want to check at all). Please add a file path to the `excludes.txt` file matching the containing file. File paths are Perl 5 Regular Expressions - you can [test]( https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your files. `^` refers to the file's path from the root of the repository, so `^README\.md$` would exclude [README.md]( ../tree/HEAD/README.md) (on whichever branch you're using). * well-formed pattern. If you can write a [pattern](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples:-patterns) that would match it, try adding it to the `patterns.txt` file. Patterns are Perl 5 Regular Expressions - you can [test]( https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your lines. Note that patterns can't match multiline strings.
Gijsreyn commented 2 weeks ago

Hi @Trenly, I don't know why I had to add itsdangerouss twice to the list, but afterwards, it succeeded. FYI.

Trenly commented 2 weeks ago

Hi @Trenly, I don't know why I had to add itsdangerouss twice to the list, but afterwards, it succeeded. FYI.

Interesting; @jsoref might know

jsoref commented 2 weeks ago

I'm not sure what's going on with itsdangerouss either... very strange. I'm currently poking a couple of other bugs I've turned up. Once i've cleared them, I'm going to take a deeper dive here...

jsoref commented 2 weeks ago

For itsdangerouss, my guess is that the allow file is missing a new-line-at-eof -- which is confirmed by https://github.com/check-spelling-sandbox/winget-dsc/commit/b47129778cfbeba581896b2af336ba826ebcf500.patch clearing the problem up in https://github.com/check-spelling-sandbox/winget-dsc/actions/runs/11707189285. I thought check-spelling had enough checks to warn about that instead of breaking -- I should be able to fix that shortly.

Note that itsdangerouss should be able to go into expect.txt instead, and it should probably be possible to construct a string that is composed of dictionary words and possibly punctuation instead of using something that isn't in the dictionary. depending on things, that could be: its-dangerous, itsDangerous, its1dangerous, itsdangerous_ its_dangerous, or something else. The trailing s in itsdangerouss feels like a typo.

Gijsreyn commented 2 weeks ago

Good point and Kaleb reminded me as well to add it to the correct files.

jsoref commented 2 weeks ago

Thanks for the heads-up about itsdangerouss, I'm tracking it here:

And it's fixed in prerelease as you can see from this report # @check-spelling-bot Report ## :red_circle: Please review ### See the [:scroll:action log](https://github.com/check-spelling-sandbox/winget-dsc/actions/runs/11709369433/job/32614621831#step:4:1) or [:memo: job summary](https://github.com/check-spelling-sandbox/winget-dsc/actions/runs/11709369433/attempts/7#summary-32614621831) for details. ### Unrecognized words (1) confrimation
These words are not needed and should be removed Toolpackage

To accept these unrecognized words as correct, you could apply this commit ... in a clone of the [git@github.com:check-spelling-sandbox/winget-dsc.git](https://github.com/check-spelling-sandbox/winget-dsc.git) repository on the `whatif-support` branch ([:information_source: how do I use this?]( https://docs.check-spelling.dev/Accepting-Suggestions)): ```sh git am <<'@@@@3eac0379655cc021222446138658baab9bcfb18e--1730918238' From 390626c4aa116fb728a7685be732bcec4c67aafa Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Wed, 6 Nov 2024 18:37:17 +0000 Subject: [PATCH] [check-spelling] Update metadata check-spelling run (push) for whatif-support Signed-off-by: check-spelling-bot on-behalf-of: @check-spelling --- .../spelling/expect/588ee95ffe45b0dc6a84d481385ef17a835297ee.txt | 1 + .github/actions/spelling/expect/software.txt | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) create mode 100644 .github/actions/spelling/expect/588ee95ffe45b0dc6a84d481385ef17a835297ee.txt diff --git a/.github/actions/spelling/expect/588ee95ffe45b0dc6a84d481385ef17a835297ee.txt b/.github/actions/spelling/expect/588ee95ffe45b0dc6a84d481385ef17a835297ee.txt new file mode 100644 index 0000000..e8309cb --- /dev/null +++ b/.github/actions/spelling/expect/588ee95ffe45b0dc6a84d481385ef17a835297ee.txt @@ -0,0 +1 @@ +confrimation diff --git a/.github/actions/spelling/expect/software.txt b/.github/actions/spelling/expect/software.txt index 8ed24f0..82e7f85 100644 --- a/.github/actions/spelling/expect/software.txt +++ b/.github/actions/spelling/expect/software.txt @@ -5,4 +5,3 @@ dotnettool cspell NUnit reportgenerator -Toolpackage -- 2.47.0 @@@@3eac0379655cc021222446138658baab9bcfb18e--1730918238 ``` And `git push` ...
**OR**
To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands ... in a clone of the [git@github.com:check-spelling-sandbox/winget-dsc.git](https://github.com/check-spelling-sandbox/winget-dsc.git) repository on the `whatif-support` branch ([:information_source: how do I use this?]( https://docs.check-spelling.dev/Accepting-Suggestions)): ``` sh curl -s -S -L 'https://raw.githubusercontent.com/check-spelling-sandbox/check-spelling/prerelease/apply.pl' | perl - 'https://github.com/check-spelling-sandbox/winget-dsc/actions/runs/11709369433/attempts/7' ```
Pattern suggestions :scissors: (3) You could add these patterns to `.github/actions/spelling/patterns.txt`: ``` # Automatically suggested patterns # hit-count: 13 file-count: 5 # Compiler flags (?:^|[\t ,"'`=(])-[DPWXYLlf](?=[A-Z]{2,}|[A-Z][a-z]|[a-z]{2,}) # hit-count: 3 file-count: 1 # githubusercontent /[-a-z0-9]+\.githubusercontent\.com/[-a-zA-Z0-9?&=_\/.]* # hit-count: 2 file-count: 1 # GitHub SHAs (markdown) (?:\[`?[0-9a-f]+`?\]\(https:/|)/(?:www\.|)github\.com(?:/[^/\s"]+){2,}(?:/[^/\s")]+)(?:[0-9a-f]+(?:[-0-9a-zA-Z/#.]*|)\b|) ```
Warnings (2) #### See the [:scroll:action log](https://github.com/check-spelling-sandbox/winget-dsc/actions/runs/11709369433/job/32614621831#step:4:1) or [:memo: job summary](https://github.com/check-spelling-sandbox/winget-dsc/actions/runs/11709369433/attempts/7#summary-32614621831) for details. [:warning: Warnings](https://docs.check-spelling.dev/Event-descriptions) | Count -|- [:information_source: candidate-pattern](https://docs.check-spelling.dev/Event-descriptions#candidate-pattern) | 5 [:warning: no-newline-at-eof](https://docs.check-spelling.dev/Event-descriptions#no-newline-at-eof) | 1 See [:warning: Event descriptions](https://docs.check-spelling.dev/Event-descriptions) for more information.
If the flagged items are :exploding_head: false positives If items relate to a ... * binary file (or some other file you wouldn't want to check at all). Please add a file path to the `excludes.txt` file matching the containing file. File paths are Perl 5 Regular Expressions - you can [test]( https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your files. `^` refers to the file's path from the root of the repository, so `^README\.md$` would exclude [README.md]( ../tree/HEAD/README.md) (on whichever branch you're using). * well-formed pattern. If you can write a [pattern](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples:-patterns) that would match it, try adding it to the `patterns.txt` file. Patterns are Perl 5 Regular Expressions - you can [test]( https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your lines. Note that patterns can't match multiline strings.
Details :mag_right:
:open_file_folder: candidate-pattern note|path -|- `Line` matches candidate pattern `(?:\[`?[0-9a-f]+`?\]\(https:/\|)/(?:www\.\|)github\.com(?:/[^/\s"]+){2,}(?:/[^/\s")]+)(?:[0-9a-f]+(?:[-0-9a-zA-Z/#.]*\|)\b\|)` | https://github.com/check-spelling-sandbox/winget-dsc/blame/588ee95ffe45b0dc6a84d481385ef17a835297ee/.github/workflows/spellCheck.yaml#L78 `Line` matches candidate pattern `(?:^\|[\t ,"'`=(])-[DPWXYLlf](?=[A-Z]{2,}\|[A-Z][a-z]\|[a-z]{2,})` | https://github.com/check-spelling-sandbox/winget-dsc/blame/588ee95ffe45b0dc6a84d481385ef17a835297ee/resources/Microsoft.DotNet.Dsc/Microsoft.DotNet.Dsc.psm1#L142 `Line` matches candidate pattern `(?:^\|[\t ,"'`=(])-[DPWXYLlf](?=[A-Z]{2,}\|[A-Z][a-z]\|[a-z]{2,})` | https://github.com/check-spelling-sandbox/winget-dsc/blame/588ee95ffe45b0dc6a84d481385ef17a835297ee/resources/Microsoft.Windows.Developer/Microsoft.Windows.Developer.psm1#L184 `Line` matches candidate pattern `(?:^\|[\t ,"'`=(])-[DPWXYLlf](?=[A-Z]{2,}\|[A-Z][a-z]\|[a-z]{2,})` | https://github.com/check-spelling-sandbox/winget-dsc/blame/588ee95ffe45b0dc6a84d481385ef17a835297ee/resources/Microsoft.Windows.Setting.Accessibility/Microsoft.Windows.Setting.Accessibility.psm1#L292 `Line` matches candidate pattern `/[-a-z0-9]+\.githubusercontent\.com/[-a-zA-Z0-9?&=_\/.]*` | https://github.com/check-spelling-sandbox/winget-dsc/blame/588ee95ffe45b0dc6a84d481385ef17a835297ee/.github/workflows/spellCheck.yaml#L79
:open_file_folder: no-newline-at-eof note|path -|- No newline at eof. | https://github.com/check-spelling-sandbox/winget-dsc/blame/588ee95ffe45b0dc6a84d481385ef17a835297ee/.github/actions/spelling/allow.txt#L42
:open_file_folder: unrecognized-spelling note|path -|- `confrimation` is not a recognized word. | https://github.com/check-spelling-sandbox/winget-dsc/blame/588ee95ffe45b0dc6a84d481385ef17a835297ee/resources/PythonPip3Dsc/PythonPip3Dsc.psm1#L208
ryfu-msft commented 1 week ago

/azp run

azure-pipelines[bot] commented 1 week ago
Azure Pipelines successfully started running 1 pipeline(s).
ryfu-msft commented 1 week ago

/azp run

azure-pipelines[bot] commented 1 week ago
Azure Pipelines successfully started running 1 pipeline(s).
github-actions[bot] commented 1 week ago

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

Unrecognized words (1)

itsdangerouss

These words are not needed and should be removed actions alpha because characters contains cspell dictionary entry expect generic github Ignoring non spelling terms Toolpackage txt Warning Workaround

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands ... in a clone of the [git@github.com:Gijsreyn/winget-dsc.git](https://github.com/Gijsreyn/winget-dsc.git) repository on the `whatif-support` branch ([:information_source: how do I use this?]( https://docs.check-spelling.dev/Accepting-Suggestions)): ``` sh curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.24/apply.pl' | perl - 'https://github.com/microsoft/winget-dsc/actions/runs/11800079307/attempts/1' ```
Errors (1) #### See the [:open_file_folder: files](https://github.com/microsoft/winget-dsc/pull/89/files/) view, the [:scroll:action log](https://github.com/microsoft/winget-dsc/actions/runs/11800079307/job/32870143503#step:4:1), or [:memo: job summary](https://github.com/microsoft/winget-dsc/actions/runs/11800079307/attempts/1#summary-32870143503) for details. [:x: Errors](https://docs.check-spelling.dev/Event-descriptions) | Count -|- [:x: forbidden-pattern](https://docs.check-spelling.dev/Event-descriptions#forbidden-pattern) | 25 See [:x: Event descriptions](https://docs.check-spelling.dev/Event-descriptions) for more information.
If the flagged items are :exploding_head: false positives If items relate to a ... * binary file (or some other file you wouldn't want to check at all). Please add a file path to the `excludes.txt` file matching the containing file. File paths are Perl 5 Regular Expressions - you can [test]( https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your files. `^` refers to the file's path from the root of the repository, so `^README\.md$` would exclude [README.md]( ../tree/HEAD/README.md) (on whichever branch you're using). * well-formed pattern. If you can write a [pattern](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples:-patterns) that would match it, try adding it to the `patterns.txt` file. Patterns are Perl 5 Regular Expressions - you can [test]( https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your lines. Note that patterns can't match multiline strings.
Gijsreyn commented 1 week ago

@ryfu-msft I checked the logs and I saw what went wrong. Just commited a fix that makes sure the package is always uninstall, before doing whatif to meet the satisfaction

github-actions[bot] commented 1 week ago

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors Count
:x: forbidden-pattern 25

See :x: Event descriptions for more information.

These words are not needed and should be removed actions alpha because characters contains cspell dictionary entry expect generic github Ignoring non spelling terms Toolpackage txt Warning Workaround

If the flagged items are :exploding_head: false positives If items relate to a ... * binary file (or some other file you wouldn't want to check at all). Please add a file path to the `excludes.txt` file matching the containing file. File paths are Perl 5 Regular Expressions - you can [test]( https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your files. `^` refers to the file's path from the root of the repository, so `^README\.md$` would exclude [README.md]( ../tree/HEAD/README.md) (on whichever branch you're using). * well-formed pattern. If you can write a [pattern](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples:-patterns) that would match it, try adding it to the `patterns.txt` file. Patterns are Perl 5 Regular Expressions - you can [test]( https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your lines. Note that patterns can't match multiline strings.
ryfu-msft commented 1 week ago

/azp run

azure-pipelines[bot] commented 1 week ago
Azure Pipelines successfully started running 1 pipeline(s).
github-actions[bot] commented 1 week ago

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors Count
:x: forbidden-pattern 25

See :x: Event descriptions for more information.

These words are not needed and should be removed actions alpha because characters contains cspell dictionary entry expect generic github Ignoring non spelling terms Toolpackage txt Warning Workaround

If the flagged items are :exploding_head: false positives If items relate to a ... * binary file (or some other file you wouldn't want to check at all). Please add a file path to the `excludes.txt` file matching the containing file. File paths are Perl 5 Regular Expressions - you can [test]( https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your files. `^` refers to the file's path from the root of the repository, so `^README\.md$` would exclude [README.md]( ../tree/HEAD/README.md) (on whichever branch you're using). * well-formed pattern. If you can write a [pattern](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples:-patterns) that would match it, try adding it to the `patterns.txt` file. Patterns are Perl 5 Regular Expressions - you can [test]( https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your lines. Note that patterns can't match multiline strings.
ryfu-msft commented 1 week ago

@Gijsreyn , you still have issues with spelling, you can probably avoid having to mess with that if you just did something simple like invalidPackageName

ryfu-msft commented 1 week ago

/azp run

azure-pipelines[bot] commented 1 week ago
Azure Pipelines successfully started running 1 pipeline(s).
Gijsreyn commented 1 week ago

@ryfu-msft I went with the suggestion from Josh, but just changed it.

Gijsreyn commented 1 week ago

I'm doing something terrible wrong Ryan. Shouldn't be writing code when I'm death tired. Sorry for the tiny commits.

ryfu-msft commented 1 week ago

/azp run

azure-pipelines[bot] commented 1 week ago
Azure Pipelines successfully started running 1 pipeline(s).
ryfu-msft commented 1 week ago

I'm doing something terrible wrong Ryan. Shouldn't be writing code when I'm death tired. Sorry for the tiny commits.

Haha no need to apologize. Thank you for your contribution, this is really great. Everything looks good to me, lets get this checked in and published!