[Package Issue]: Mozilla.Thunderbird

FurtadoPires commented 1 year ago

Please confirm these before moving forward

[X] I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
[X] I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue

Installation issue.

Brief description of your issue

Thunderbird beta is being offered as a update for those who have thunderbird pt-br stable installed (I haven't checked if other languages have the same problem)

Steps to reproduce

Install the latest thunderbird stable, then run winget --upgrade

Actual behavior

winget will offer the the version xxx.xbx despite not having a beta version installed

Expected behavior

it should only offer beta updates to those who have a beta version installed

Environment

Gerenciador de Pacotes do Windows v1.5.2201
Copyright (c) Microsoft Corporation. Todos os direitos reservados.

Windows: Windows.Desktop v10.0.22621.2134
Arquitetura do Sistema: X64
Pacote: Microsoft.DesktopAppInstaller v1.20.2201.0

Winget Directories
-------------------------------------------------------------------------------------------------------------------------------
Logs                               %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir
User Settings                      %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\settings.json
Portable Links Directory (User)    %LOCALAPPDATA%\Microsoft\WinGet\Links
Portable Links Directory (Machine) C:\Program Files\WinGet\Links
Portable Package Root (User)       %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portable Package Root              C:\Program Files\WinGet\Packages
Portable Package Root (x86)        C:\Program Files (x86)\WinGet\Packages

Links
-------------------------------------------------------------------------------
Política de Privacidade https://aka.ms/winget-privacy
Contrato de Licença     https://aka.ms/winget-license
Avisos de Terceiros     https://aka.ms/winget-3rdPartyNotice
Home page               https://aka.ms/winget
Termos da Windows Store https://www.microsoft.com/en-us/storedocs/terms-of-sale

Configuração do Administrador             Estado
------------------------------------------------------
LocalManifestFiles                        Desabilitado
BypassCertificatePinningForMicrosoftStore Desabilitado
InstallerHashOverride                     Desabilitado
LocalArchiveMalwareScanOverride           Desabilitado

Screenshots and Logs

No response

Danik1601 commented 1 year ago

+1 here.

Winget upgraded me from 115 (stable) to 117b4 and now offers 117b6.

P.S. My installation languages are en-us and ru-ru.

R-Adrian commented 1 year ago

same problem shows up for me, winget wants to "upgrade" my stable Thunderbird x64 en-gb 115.1.1 to beta version 117.0b6

https://ftp.mozilla.org/pub/thunderbird/releases/115.1.1/win64/en-GB/

cela96 commented 1 year ago

I have the same issue. Until a few minutes ago, I had an old version, probably 102.x.x installed via .exe I assume that there is no automatic update from 102.x.x to Supernova 115.x.x winget upgrade saw 102.x.x as Mozilla Thunderbird (x64 it) Mozilla.Thunderbird.Beta > 117.0b4 117.0b6 winget

At this point, I manually updated to the latest stable version via the Italian .msi file available on the official website https://download-installer.cdn.mozilla.net/pub/thunderbird/releases/115.1.1/win64/it/Thunderbird%20Setup%20115.1.1.msi

Winget continued to see it as Mozilla.Thunderbird.Beta

Then, I forced the installation of the stable version using winget install -e --id Mozilla.Thunderbird --force effectively downgrading from 115.1.1 to 115.0. Winget used this link https://download-installer.cdn.mozilla.net/pub/thunderbird/releases/115.0/win64/it/Thunderbird%20Setup%20115.0.msi

After doing this, winget upgrade now sees Thunderbird as Mozilla Thunderbird (x64 it) Mozilla.Thunderbird 115.0 117.0b6 winget so it's identified correctly.

However, it still wants to update it to the beta version. After opening and closing Thunderbird (triggering the integrated automatic update), winget upgrade reports Mozilla Thunderbird (x64 it) Mozilla.Thunderbird 115.1.1 117.0b6 winget

R-Adrian commented 1 year ago

I think this probably happens because Winget currently only considers as "stable" the version 115.0 because there is no other manifest published for the newer 115.x.y versions and when it encounters a higher version number, it assumes that the currently installed one must be a newer/beta version of Thunderbird and it starts to look at the manifests for the beta versions.... and those have an even higher version number (117).

https://github.com/microsoft/winget-pkgs/tree/master/manifests/m/Mozilla/Thunderbird

fblz commented 1 year ago

At least in my example #118246 I did not start Thunderbird at all, neither did I invoke the integrated updater. So there is probably a problem outside the package sources.

dpprdan commented 1 year ago

I suspect, winget cannot tell the beta from the stable version, because both have the same (apart from the version number) ARP entries:

Stable:

DisplayName                     DisplayVersion Publisher ProductCode                             Scope
-----------                     -------------- --------- -----------                             -----
Mozilla Thunderbird (x64 en-US) 115.2.2        Mozilla   Mozilla Thunderbird 115.2.2 (x64 en-US) Machine

Beta:

DisplayName                     DisplayVersion Publisher ProductCode                           Scope
-----------                     -------------- --------- -----------                           -----
Mozilla Thunderbird (x64 en-US) 118.0          Mozilla   Mozilla Thunderbird 118.0 (x64 en-US) Machine

Compare Firefox:

DisplayName                 DisplayVersion Publisher ProductCode                         Scope
-----------                 -------------- --------- -----------                         -----
Mozilla Firefox (x64 en-US) 117.0.1        Mozilla   Mozilla Firefox 117.0.1 (x64 en-US) Machine

DisplayName                           DisplayVersion Publisher ProductCode                                 Scope
-----------                           -------------- --------- -----------                                 -----
Firefox Developer Edition (x64 en-US) 118.0          Mozilla   Firefox Developer Edition 118.0 (x64 en-US) Machine

@jedieaston (since you submitted the latest Firefox manifests) is there something we can do here to tell them apart? UpgradeCode or something like that maybe? Or does this have to be fixed by the Thunderbird team?

TheNavyBear commented 1 year ago

Same issue. For a few weeks winget just showed the Beta version as an available upgrade with 'winget upgrade' but did not upgrade it with 'winget upgrade --all'. As of this week winget now installs Thunderbird Beta in parallel with my Thunderbird 115.xx when I run 'winget upgrade --all'. I have had to pin Thunderbird in winget to avoid this. This is a bandaid approach as I can no longer use winget to see if/when there is an update to Thunderbird non-beta, and must now rely on Thunderbird's in-built updater instead of winget...

dpprdan commented 1 year ago

Related issues on Thunderbird's Bugzilla:

trparky commented 1 year ago

OK, but shouldn't pinning Thunderbird prevent Winget from telling me that there's an upgrade? I've tried to pin it like I have done with another program and yet, it doesn't behave the same way.

dpprdan commented 1 year ago

The current workaround is that all beta manifests with versions larger than the current stable version have been purged from the repo, see https://github.com/microsoft/winget-pkgs/issues/117949#issuecomment-1745479231:

The actual fix would be to address the problem in Support different release channels [released, beta, alpha] winget-cli#147

Or (as mentioned above) that Thunderbird uses a different ARP name for beta versions.

microsoft / winget-pkgs