microsoft / winget-pkgs

The Microsoft community Windows Package Manager manifest repository
MIT License
8.53k stars 4.43k forks source link

[Package Issue]: ImageMagick.ImageMagick version in winget source doesn't exist anymore #120261

Open sba923 opened 1 year ago

sba923 commented 1 year ago

Please confirm these before moving forward

Category of the issue

Other

Brief description of your issue

winget list ImageMagick.ImageMagick reports that version 7.1.1.16 is available; as a consequence winget upgrade ImageMagick.ImageMagick attempts to download https://imagemagick.org/archive/binaries/ImageMagick-7.1.1-16-Q16-HDRI-x64-dll.exe which no longer exists and has been superseded by https://imagemagick.org/archive/binaries/ImageMagick-7.1.1-17-Q16-HDRI-x64-dll.exe

Steps to reproduce

Run winget upgrade ImageMagick.ImageMagick on a system with version 7.1.1.15 installed.

Actual behavior

PS> winget upgrade ImageMagick
Found ImageMagick [ImageMagick.ImageMagick] Version 7.1.1.16
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://imagemagick.org/archive/binaries/ImageMagick-7.1.1-16-Q16-HDRI-x64-dll.exe
An unexpected error occurred while executing the command:
Download request status is not success.
0x80190194 : Not found (404).

Expected behavior

PS> winget upgrade ImageMagick
Found ImageMagick [ImageMagick.ImageMagick] Version 7.1.1.17
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://imagemagick.org/archive/binaries/ImageMagick-7.1.1-17-Q16-HDRI-x64-dll.exe

followed by successful upgrade.

Environment

Windows Package Manager v1.5.2201
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.19045.3448
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.20.2201.0

Winget Directories
-------------------------------------------------------------------------------------------------------------------------------
Logs                               %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir
User Settings                      %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\settings.json
Portable Links Directory (User)    %LOCALAPPDATA%\Microsoft\WinGet\Links
Portable Links Directory (Machine) C:\Program Files\WinGet\Links
Portable Package Root (User)       %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portable Package Root              C:\Program Files\WinGet\Packages
Portable Package Root (x86)        C:\Program Files (x86)\WinGet\Packages

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Admin Setting                             State
--------------------------------------------------
LocalManifestFiles                        Disabled
BypassCertificatePinningForMicrosoftStore Disabled
InstallerHashOverride                     Disabled
LocalArchiveMalwareScanOverride           Disabled

Screenshots and Logs

No response

otto-liljalaakso-nt commented 12 months ago

7.1.1.17 is gone from upstream download site as well, replaced by 7.1.1.18. So I have similar failure, just with different version numbers:

> winget upgrade --all
Name                                                Id                      Version  Available Source
-----------------------------------------------------------------------------------------------------
ImageMagick 7.1.1-15 Q16-HDRI (64-bit) (2023-07-30) ImageMagick.ImageMagick 7.1.1.15 7.1.1.17  winget
2 upgrades available.
5 package(s) have pins that prevent upgrade. Use the 'winget pin' command to view and edit pins. Using the --include-pinned argument may show more results.

(1/1) Found ImageMagick [ImageMagick.ImageMagick] Version 7.1.1.17
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://imagemagick.org/archive/binaries/ImageMagick-7.1.1-17-Q16-HDRI-x64-dll.exe
An unexpected error occurred while executing the command:
Download request status is not success.
0x80190194 : Not found (404).
otto-liljalaakso-nt commented 12 months ago

I just successfully got 7.1.1.18 from Winget. This issue is resolved now. (Unless upstream decides to again pull a release from their site, of course.)

pedrohgmacedo commented 10 months ago

This issue is resolved now. (Unless upstream decides to again pull a release from their site, of course.)

Narrator: That's exactly what happened in 7.1.1-20

BrandonWanHuanSheng commented 10 months ago

It seem like different URL every time.

BrandonWanHuanSheng commented 10 months ago

I also noticed that ImageMagick is also in github.com and sourceforge.net

https://github.com/ImageMagick/ImageMagick/discussions/6832

otto-liljalaakso-nt commented 10 months ago

Right, it looks like https://imagemagick.org/archive/binaries/ only contains the latest version for each major release series. So the only way to fix this issue is to work with upstream to make the releases available for longer time. Thank you opening the upstream discussion @BrandonWanHuanSheng.

aa956 commented 7 months ago

And looks like ImageMagick is just removed now?

PS C:\> winget search ImageMagick
No package found matching input criteria.
PS C:\> winget install -e --id ImageMagick.ImageMagick
No package found matching input criteria.
PS C:\>
mdanish-kh commented 7 months ago

And looks like ImageMagick is just removed now?

It should be back now through PR https://github.com/microsoft/winget-pkgs/pull/136984. It got removed by automation because the URLs for were 404. This is because the package didn't get updated enough in the repo and the publisher only retains URLs for the latest version. I've opened https://github.com/microsoft/winget-pkgs/issues/136983 to prevent cases like these to occur in the future

aa956 commented 7 months ago

It should be back now through PR #136984. It got removed by automation because the URLs for were 404. This is because the package didn't get updated enough in the repo and the publisher only retains URLs for the latest version. I've opened #136983 to prevent cases like these to occur in the future

Thank you, it is back now!

PS C:\> winget search ImageMagick.ImageMagick
Name        Id                      Version  Source
----------------------------------------------------
ImageMagick ImageMagick.ImageMagick 7.1.1.27 winget
PS C:\>
DenWin commented 7 months ago

And looks like ImageMagick is just removed now?

It should be back now through PR #136984. It got removed by automation because the URLs for were 404. This is because the package didn't get updated enough in the repo and the publisher only retains URLs for the latest version. I've opened #136983 to prevent cases like these to occur in the future

Thks, for bringing it back, thought this issue was left out, now that it was restored from scratch: https://github.com/microsoft/winget-pkgs/commit/1c79516c3c729bd93574e8ee4fd845c6a3e8cafd