microsoft / winget-pkgs

The Microsoft community Windows Package Manager manifest repository
MIT License
8.47k stars 4.36k forks source link

Regression: Azure Pipelines failing on manifest that contains dependencies #135625

Open Cyberboss opened 7 months ago

Cyberboss commented 7 months ago

I'm facing an unknown issue preventing my package from being validated. Refer to https://github.com/microsoft/winget-pkgs/pull/132245, https://github.com/microsoft/winget-pkgs/pull/133023, and https://github.com/microsoft/winget-pkgs/pull/135613.

I recently ran a test to prove a change in my package wasn't a change in my code. 6.1.0 was originally submitted in https://github.com/microsoft/winget-pkgs/pull/132002 and validated successfully. The exact same manifest (and therefore, installer) with a different version number failed validation today (https://github.com/microsoft/winget-pkgs/pull/135622).

I am unable to diagnose this issue further do to the validation logs seemingly being unavailable to the public.

github-actions[bot] commented 7 months ago

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

Trenly commented 7 months ago

It looks like this is an issue with the dependencies -

2024-01-20 20:20:14.526 [CORE] WinINet downloading from url: https://cdn.winget.microsoft.com/cache/manifests/m/Microsoft/DotNet/HostingBundle/8/8.0.1/f982
2024-01-20 20:20:14.542 [CORE] Download hash: bbb67cb3c8300f8168edf9863a74028a873ebe614773b03df4652af2d7855160
2024-01-20 20:20:14.542 [CORE] Download completed.
2024-01-20 20:20:14.543 [CLI ] Starting installer selection.
2024-01-20 20:20:14.543 [CLI ] Installer [X86,burn,Unknown,] not applicable: Installer locale does not match required locale: Required locales: [en-us] Or does not satisfy compatible match for Preferred Locales: [en-US]
2024-01-20 20:20:14.543 [CLI ] Installer [X86,burn,Unknown,] not applicable: Installer scope does not match required scope: Unknown != Machine
2024-01-20 20:20:14.545 [CLI ] No suitable installer found for manifest Microsoft.DotNet.HostingBundle.8 with version 8.0.1

The full InstallationVerification logs are available in the Validation Pipeline - https://dev.azure.com/ms/winget-pkgs/_build/results?buildId=533897&view=artifacts&pathAsName=false&type=publishedArtifacts

You can get there by going to your PR, clicking on "Checks", then "Azure Pipelines" => "WinGetSvc-Validation" => "View more details on Azure Pipelines" and then looking for the "Artifacts"

image

Trenly commented 7 months ago

@denelon - looks like Unknown isn't being considered applicable for dependencies, when it really should be

Cyberboss commented 7 months ago

Thanks for pointing that out. Knowing it's the dependency spec, I can actually remove that since it's a bundled .msi in my installer.

I assume you want me to leave this issue open to triage the pipelines issue?

Cyberboss commented 7 months ago

Updated title appropriately. Note that this used to work fine last year

dougmassay commented 4 months ago

Any more on this? I'm getting similar inexplicable failures with a manifest that has a microsoft.VCRedist.2015+.x64 dependency.

https://github.com/microsoft/winget-pkgs/pull/147284#issuecomment-2030957187