search

microsoft / winget-pkgs

The Microsoft community Windows Package Manager manifest repository
MIT License
8.69k stars 4.53k forks source link

About app version #13667

Closed KaranKad closed 3 years ago

KaranKad commented 3 years ago

Some apps have long release number on their website and in about section of the app, but when installed, control panel/settings app show the release in short version.

In about section and website

image image

In settings app

image

If I keep the manifest according to the app and website, winget thinks the app is outdated because it checks the app version according to control panel/settings app and tries to install it.

I have latest version of CPU-Z v1.96.1 installed but the app in control panel reports as 1.96, so winget thinks its outdated and tries to upgrade the app.

In about section

image

winget upgrade command showing app has update

image

In settings app

image

Some apps don't have version number at all

image image

This would be a non issue if apps reported their version properly, but sadly they don't.

OfficialEsco commented 3 years ago

Since winget upgrade just got out of experimental there is a few issues, WinGet is looking at the version which is shown in the Control Panel/Settings App (Which is the version you should type in the Version field)

Main issue thread: https://github.com/microsoft/winget-cli/issues/976 Feature Request for the bot: https://github.com/microsoft/winget-pkgs/issues/13620 Alternative Version Feature Request: https://github.com/microsoft/winget-cli/issues/980

I also see that winget upgrade is trying to upgrade to latest, which IMO it should not try to do

KaranKad commented 3 years ago

Control Panel/Settings App (Which is the version you should type in the Version field)

I will update manifests according to it then.

jedieaston commented 3 years ago

I also see that winget upgrade is trying to upgrade to latest, which IMO it should not try to do

It tries to do this for Spotify too, which is rather annoying. At least MSIs are upgraded right now which is nice.

denelon commented 3 years ago

We're tracking Issues in the client repository where we think logic changes might help. I think I've seen most of these reported on https://github.com/microsoft/winget-cli/issues/976. I'm going to go ahead and convert this to a discussion, so it isn't closed as an issue.

The current experimental store source doesn't report versions for packages. All we have is "latest" as a sentinel value. That results in store packages always thinking there is an upgrade available. Packages installed from the store generally get automatically updated as long as no policy restricts that behavior.

I'm interested in more discussion here around maybe changing to version "unknown" or something like that so the behavior could make more sense. Maybe we need an option for upgrade to try upgrading things marked "latest" or "unknown".

Spotify is behind a vanity URL and the installer changes frequently. It's been quite a challenge to keep the right hash on the manifest. We've added a couple of features to try and help. https://github.com/microsoft/winget-cli/issues/870 and https://github.com/microsoft/winget-cli/issues/920.