Open ghost opened 9 months ago
Hi I'm an AI powered bot that finds similar issues based off the issue title.
Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!
Note: You can give me feedback by thumbs upping or thumbs downing this comment.
I believe this depends on:
I believe the other problem (and why I didn't include ffmpeg as a dependency in my yt-dlp PRs) is that ffmepg isn't required for the operation of yt-dl, it's needed when remuxing or converting audio/video tracks, in which case the program informs the user that ffmpeg is needed.
Would it not be best left to user choice on their installation method of this optional tool, especially given a user may already have ffmpeg available in path via an alternative means (choco for example places it in a directory within C:\programdata\choco\bin\
or something close to that effect iirc) and our dependency throws another instance of it onto a PC?
If it makes sense, I think we just keep ffmpeg out of the yt-dlp installer.yamls as a dependency.
Also, yt-dl also recommends having PhantomJS installed in some instances, yet we don't throw that in by default 😅
I believe the other problem (and why I didn't include ffmpeg as a dependency in my yt-dlp PRs) is that ffmepg isn't required for the operation of yt-dl, it's needed when remuxing or converting audio/video tracks, in which case the program informs the user that ffmpeg is needed.
If some form of FFmpeg
isn't present, then I believe yt-dlp
throws an error.
Would it not be best left to user choice on their installation method of this optional tool, especially given a user may already have ffmpeg available in path via an alternative means (choco for example places it in a directory within
C:\programdata\choco\bin\
or something close to that effect iirc) and our dependency throws another instance of it onto a PC?
This is the goal behind the Issue that mdanish-kh linked.
If it makes sense, I think we just keep ffmpeg out of the yt-dlp installer.yamls as a dependency.
The error I mentioned above might block pipeline validation approval, or result in a poor user experience for users who don't have FFmpeg
installed and don't know about it - they install a new application, get an error, and think poorly of our package manager system for allowing errant packages.
Also, yt-dl also recommends having PhantomJS installed in some instances, yet we don't throw that in by default 😅
Maybe we should. It's not in the repo yet, but appears to be a portable
type of package.
looping installation
installing Gyan.FFmpeg.Shared doesn't even properly add ffmpeg to my PATH in my case
Gyan.FFmpeg fixes this tho
Please confirm these before moving forward
Category of the issue
Other
Brief description of your issue
yt-dlp.yt-dlp
hard depends onGyan.FFmpeg
, but there's alsoGyan.FFmpeg.Shared
, who want/need the libraries provided by ffmpeg, so having 2 packages that provide the same thing isn't really ideal.Steps to reproduce
winget install yt-dlp
Actual behavior
it installs
Gyan.FFmpeg
, even if i already haveGyan.FFmpeg.Shared
installedExpected behavior
either the ability to choose which ffmpeg package to install or having a separate package called yt-dlp (shared)
Environment
Screenshots and Logs
No response