search

microsoft / winget-pkgs

The Microsoft community Windows Package Manager manifest repository
MIT License
8.56k stars 4.45k forks source link

[Package Request]: Files #150390

Closed Kaligula0 closed 1 week ago

Kaligula0 commented 5 months ago

How can we help?

I would like someone else to build the manifest.

Please read and ensure the following

Please provide the following information

Download Page Url: https://files.community/download Publisher: Files Community Package Name: Files Description: The ultimate, free, open-source file manager app for Windows Package Version: 3.3 Installer URL: https://cdn.files.community/files/download/Files.Stable.exe (available also via MS Store)

Source code on GitHub https://github.com/files-community/Files

Kaligula0 commented 5 months ago

I wanted to cross-post to https://github.com/files-community/Files and found a closed issue https://github.com/files-community/Files/issues/8653 pointing to closed PR here https://github.com/microsoft/winget-pkgs/pull/146185

Josh65-2201 commented 5 months ago

I attempted this in #150392 it fails with no error given. Local install seem like it doesn't even try download the installer before opening. immediately shows exit code: 0x80070570 : The file or directory is corrupted and unreadable.

https://cdn.files.community/files/stable/Files.Package_3.3.0.0_Stable_Test/Files.Package_3.3.0.0_x64_arm64_Stable.msixbundle
BiosPlus commented 5 months ago

Given it's already on the MS Store, it can also be installed with winget install 9nghp3dx8hdx

image

Beneficial as I believe they have a github workflow which uploads new versions to the MSStore anyway.

Josh65-2201 commented 5 months ago

Files on the store is paid where as there are the free options and preview builds would also not be on the store

stephengillie commented 5 months ago

I wanted to cross-post to https://github.com/files-community/Files and found a closed issue files-community/Files#8653 pointing to closed PR here #146185

This was closed because we couldn't find silent installer switches. Do you know how to install this without user interaction?

vikingnope commented 5 months ago

@stephengillie, this is the only otherway:

image

Josh65-2201 commented 5 months ago

The offline installers are msixbundles (The one I linked above) which should work silently, what the original one used was the user installer

Kaligula0 commented 5 months ago

This was closed because we couldn't find silent installer switches. Do you know how to install this without user interaction?

No, I just learned about winget few days ago (and fell in love with), and found Files yesterday. So, naturally, I checked if Files are available via winget. I didn't find it, so posted here.

vikingnope commented 5 months ago

It is not silent:

image

The offline installers are msixbundles (The one I linked above) which should work silently, what the original one used was the user installer

stephengillie commented 5 months ago

Edit: I misunderstood your post at first.

Thanks for checking them.

Josh65-2201 commented 5 months ago

Is that shown when using Winget? Because that interface is just app installer the default open app for them.

vikingnope commented 5 months ago

The only other way is to run the command present above but I do not know how we can implement that into winget

Add-AppxPackage -AppInstallerFile https://cdn.files.community/files/stable/Files.Package.appinstaller

vikingnope commented 5 months ago

Is that shown when using Winget? Because that interface is just app installer the default open app for them.

Winget does not support interactive installers (a.k.a installers where you need to press buttons), it only supports one's where everything can be done without any interactions from the user.

Josh65-2201 commented 5 months ago

Right now the issue I'm facing is trying to get it to install the dependencies. Winget doesn't seem to find the package family Microsoft.WindowsAppRuntime.1.5_8wekyb3d8bbwe, would this have to be a separate manifest on winget or can I add the below URL to the depencides section?

https://cdn.files.community/files/stable/Files.Package_3.3.0.0_Stable_Test/Dependencies/x64/Microsoft.WindowsAppRuntime.1.5.msix
Josh65-2201 commented 5 months ago

Is that shown when using Winget? Because that interface is just app installer the default open app for them.

Winget does not support interactive installers (a.k.a installers where you need to press buttons), it only supports one's where everything can be done without any interactions from the user.

msixbundles should work silently if installed via command line. The interface your seeing is what shows when opening the file like a user. Did you also see it when trying to install from Winget using your manifest file?

vikingnope commented 5 months ago

Do you know how to implement the command into a winget manifest?

Josh65-2201 commented 5 months ago

I would assume it would do itself when downloaded. Right now it reports failing at installing the dependency so it seem it did attempt it correctly but I can't be sure until I can figure out adding where to get the dependency from.

vikingnope commented 5 months ago

Ah yes I see the issue from my past PR, creating a pull request soon

vikingnope commented 5 months ago

@Josh65-2201, does the package have any other dependencies than the Windows App SDK 1.5?

Josh65-2201 commented 5 months ago

No

vikingnope commented 5 months ago

Hmm that's weird:

image

I installed the package separately just to make sure and it still did not work

Josh65-2201 commented 5 months ago

@yaira2 The only dependency of Files is WinAppSDK 1.5 right?

Kaligula0 commented 5 months ago

(Maybe it's connected with the problems I also have trying to upgrade WinAppSDK 1.5? Although I use WingetUI, but it shows an update available but cannot update it.)

BiosPlus commented 5 months ago

If we crack open the .appinstaller package on their site with something like notepad or vscode, we'll find this for dependancies 😉

<?xml version="1.0" encoding="utf-8"?>
<AppInstaller
    Uri="https://cdn.files.community/files/stable/Files.Package.appinstaller"
    Version="3.3.0.0" xmlns="http://schemas.microsoft.com/appx/appinstaller/2018">
    <MainBundle
        Name="Files"
        Version="3.3.0.0"
        Publisher="CN=Yair Aichenbaum, O=Yair Aichenbaum, L=Baltimore, S=Maryland, C=US"
        Uri="https://cdn.files.community/files/stable/Files.Package_3.3.0.0_Stable_Test/Files.Package_3.3.0.0_x64_arm64_Stable.msixbundle" />
    <Dependencies>
        <Package
            Name="Microsoft.VCLibs.140.00"
            Publisher="CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US"
            ProcessorArchitecture="arm64"
            Uri="https://cdn.files.community/files/stable/Files.Package_3.3.0.0_Stable_Test/Dependencies/ARM64/Microsoft.VCLibs.ARM64.14.00.appx"
            Version="14.0.30704.0" />
        <Package
            Name="Microsoft.VCLibs.140.00"
            Publisher="CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US"
            ProcessorArchitecture="x64"
            Uri="https://cdn.files.community/files/stable/Files.Package_3.3.0.0_Stable_Test/Dependencies/x64/Microsoft.VCLibs.x64.14.00.appx"
            Version="14.0.30704.0" />
        <Package
            Name="Microsoft.WindowsAppRuntime.1.5"
            Publisher="CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US"
            ProcessorArchitecture="x64"
            Uri="https://cdn.files.community/files/stable/Files.Package_3.3.0.0_Stable_Test/Dependencies/x64/Microsoft.WindowsAppRuntime.1.5.msix"
            Version="5001.70.1338.0" />
        <Package
            Name="Microsoft.WindowsAppRuntime.1.5"
            Publisher="CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US"
            ProcessorArchitecture="arm64"
            Uri="https://cdn.files.community/files/stable/Files.Package_3.3.0.0_Stable_Test/Dependencies/ARM64/Microsoft.WindowsAppRuntime.1.5.msix"
            Version="5001.70.1338.0" />
        <Package
            Name="Microsoft.VCLibs.140.00.UWPDesktop"
            Publisher="CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US"
            ProcessorArchitecture="arm64"
            Uri="https://cdn.files.community/files/stable/Files.Package_3.3.0.0_Stable_Test/Dependencies/ARM64/Microsoft.VCLibs.ARM64.14.00.Desktop.appx"
            Version="14.0.30704.0" />
        <Package
            Name="Microsoft.VCLibs.140.00.UWPDesktop"
            Publisher="CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US"
            ProcessorArchitecture="x64"
            Uri="https://cdn.files.community/files/stable/Files.Package_3.3.0.0_Stable_Test/Dependencies/x64/Microsoft.VCLibs.x64.14.00.Desktop.appx"
            Version="14.0.30704.0" />
    </Dependencies>
    <UpdateSettings>
        <OnLaunch
            HoursBetweenUpdateChecks="255" />
    </UpdateSettings>
</AppInstaller>

I'll give it a shot soon.

Edit: Made some suggestions in over here: https://github.com/microsoft/winget-pkgs/pull/150504

vikingnope commented 5 months ago

Hi @BiosPlus, I cannot see any suggestions

BiosPlus commented 5 months ago

Interesting @vikingnope, here they are for context. Pretty much adding a dupe of the installer and making one arm64, and the other is adding a dependancy.

image

vikingnope commented 5 months ago

@BiosPlus, seems to have some other dependencies other than those 2:

image

stephengillie commented 5 months ago

It appears that dependency Microsoft.WindowsAppRuntime.1.5 doesn't completely install, and might be a nested installer mislabeled as a normal installer with an alias. https://github.com/microsoft/winget-pkgs/pull/150504#issuecomment-2073031989

Josh65-2201 commented 5 months ago

When Files is on Winget there is also the preview version that can be added. The name should show as Files - Preview. Link for it is below https://cdn.files.community/files/preview/Files.Package_3.6.0.0_Preview_Test/Files.Package_3.6.0.0_x64_arm64_Preview.msixbundle

Josh65-2201 commented 2 months ago

Hi, any updates on this?

vikingnope commented 2 months ago

Sadly no

Dragon1573 commented 1 month ago

image

There's a "classic installer" of the stable edition. Is it help?

vikingnope commented 1 month ago

No it does not help since it is only an interactive installer.

microsoft-github-policy-service[bot] commented 1 month ago

Hello @Kaligula0,

This package appears to require user interaction to install.

This package is blocked until support for interactive installer search filtering is implemented in:

Be sure to add your 👍 to the issue to help raise the priority and avoid posting "Me too!" messages to respect those who have subscribed to the issue.

Template: msftbot/blockingIssue/interactiveOnlyInstall

microsoft-github-policy-service[bot] commented 1 week ago

Hello @Kaligula0,

This issue has been identified as requiring a fix from a third party or external repository. Since there has been no recent activity on this issue, it will be automatically closed.

Template: msftbot/noRecentActivity/areaExternal

RokeJulianLockhart commented 1 week ago

https://github.com/microsoft/winget-pkgs/issues/150390#event-14420833064

Then don't close as completed!

Josh65-2201 commented 1 week ago

This issue has been identified as requiring a fix from a third party

I don't believe so see https://github.com/microsoft/winget-pkgs/pull/150504#issuecomment-2273691802