microsoft / winget-pkgs

The Microsoft community Windows Package Manager manifest repository
MIT License
8.68k stars 4.52k forks source link

[Package Issue]: Nikse.SubtitleEdit #156494

Closed palopezv closed 5 months ago

palopezv commented 5 months ago

Please confirm these before moving forward

Category of the issue

Other

Brief description of your issue

The latest update to Nikse.SubtitleEdit as tracked in #156068 is partially broken. The real version is 4.0.6 but the winget package reports 4.06. This will create a problem with the next update if it is 4.0.7, the most probable considering the upstream package versioning history.

Steps to reproduce

Check version line in package and compare to upstream.

Actual behavior

The package reports it is installing version 4.06.

Expected behavior

The package should report it is installing version 4.0.6.

Environment

winget --info
Windows Package Manager v1.7.11261
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22631.3672
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.22.11261.0

Winget Directories
-----------------------------------------------------------------------------------------------------------------------
Logs                               %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\Diag…
User Settings                      %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\sett…
Portable Links Directory (User)    %LOCALAPPDATA%\Microsoft\WinGet\Links
Portable Links Directory (Machine) C:\Program Files\WinGet\Links
Portable Package Root (User)       %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portable Package Root              C:\Program Files\WinGet\Packages
Portable Package Root (x86)        C:\Program Files (x86)\WinGet\Packages
Installer Downloads                %USERPROFILE%\Downloads

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Admin Setting                             State
--------------------------------------------------
LocalManifestFiles                        Disabled
BypassCertificatePinningForMicrosoftStore Disabled

Screenshots and Logs

winget update -r Name Id Version Available Source

MKVToolNix 84.0.0 (64-bit) MoritzBunkus.MKVToolNix 84.0.0 85.0.0 winget Subtitle Edit Nikse.SubtitleEdit 4.0.5.0 4.06 winget Telegram Desktop Telegram.TelegramDesktop 5.1 5.1.1 winget 3 upgrades available.

(1/3) Found MKVToolNix [MoritzBunkus.MKVToolNix] Version 85.0.0 This application is licensed to you by its owner. Microsoft is not responsible for, nor does it grant any licenses to, third-party packages. Downloading https://mkvtoolnix.download/windows/releases/85.0/mkvtoolnix-64-bit-85.0-setup.exe ██████████████████████████████ 27.8 MB / 27.8 MB Successfully verified installer hash Starting package install... Successfully installed

(2/3) Found Subtitle Edit [Nikse.SubtitleEdit] Version 4.06 This application is licensed to you by its owner. Microsoft is not responsible for, nor does it grant any licenses to, third-party packages. Downloading https://github.com/SubtitleEdit/subtitleedit/releases/download/4.0.6/SubtitleEdit-4.0.6-Setup.exe ██████████████████████████████ 10.4 MB / 10.4 MB Successfully verified installer hash Starting package install... Successfully installed

(3/3) Found Telegram Desktop [Telegram.TelegramDesktop] Version 5.1.1 This application is licensed to you by its owner. Microsoft is not responsible for, nor does it grant any licenses to, third-party packages. Downloading https://github.com/telegramdesktop/tdesktop/releases/download/v5.1.1/tsetup-x64.5.1.1.exe ██████████████████████████████ 42.9 MB / 42.9 MB Successfully verified installer hash Starting package install... Successfully installed

vikingnope commented 5 months ago

https://github.com/microsoft/winget-pkgs/pull/156464, kindly close as resolved

mdanish-kh commented 5 months ago

156464, kindly close as resolved

The publish pipeline is down at the moment (you can check the status through the status labels in README.md), so the changes there haven't been propagated. Once the PR gets the label Publish-Pipeline-Succeeded or the index gets a rebuild, we can close out this issue

seangibbz commented 5 months ago

156464, kindly close as resolved

The publish pipeline is down at the moment (you can check the status through the status labels in README.md), so the changes there haven't been propagated. Once the PR gets the label Publish-Pipeline-Succeeded or the index gets a rebuild, we can close out this issue

My pull request to fix the manifest history has been merged / succeeded and this issue can now be closed.

mdanish-kh commented 5 months ago

Close with reason: PR for removing bad version merged and published;